HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33537
Change subject: src/mainboard: Remove unused include <byteorder.h> ......................................................................
src/mainboard: Remove unused include <byteorder.h>
Change-Id: I3d638febddbd88cd4870795f96dd1bbf123c7ba3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbookair4_2/romstage.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/hp/compaq_8200_elite_sff/romstage.c M src/mainboard/hp/z220_sff_workstation/romstage.c M src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c M src/mainboard/intel/cannonlake_rvp/spd/spd_util.c M src/mainboard/intel/harcuvar/spd/spd.c M src/mainboard/intel/icelake_rvp/romstage_fsp_params.c M src/mainboard/intel/icelake_rvp/spd/spd_util.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd_util.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/kunimitsu/spd/spd.c M src/mainboard/intel/kunimitsu/spd/spd_util.c M src/mainboard/sapphire/pureplatinumh61/romstage.c 16 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/33537/1
diff --git a/src/mainboard/apple/macbookair4_2/romstage.c b/src/mainboard/apple/macbookair4_2/romstage.c index 68556d9..6fee17a 100644 --- a/src/mainboard/apple/macbookair4_2/romstage.c +++ b/src/mainboard/apple/macbookair4_2/romstage.c @@ -13,7 +13,6 @@
#include <stdint.h> #include <string.h> -#include <arch/byteorder.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <northbridge/intel/sandybridge/sandybridge.h> diff --git a/src/mainboard/google/eve/spd/spd.c b/src/mainboard/google/eve/spd/spd.c index 077bed4..fca670c 100644 --- a/src/mainboard/google/eve/spd/spd.c +++ b/src/mainboard/google/eve/spd/spd.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h> #include <gpio.h> diff --git a/src/mainboard/google/glados/spd/spd.c b/src/mainboard/google/glados/spd/spd.c index b3cf3f9..9503582 100644 --- a/src/mainboard/google/glados/spd/spd.c +++ b/src/mainboard/google/glados/spd/spd.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h> #include <gpio.h> diff --git a/src/mainboard/hp/compaq_8200_elite_sff/romstage.c b/src/mainboard/hp/compaq_8200_elite_sff/romstage.c index 4b64068..3c38877 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/romstage.c +++ b/src/mainboard/hp/compaq_8200_elite_sff/romstage.c @@ -17,7 +17,6 @@ */
#include <stdint.h> -#include <arch/byteorder.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <superio/nuvoton/npcd378/npcd378.h> diff --git a/src/mainboard/hp/z220_sff_workstation/romstage.c b/src/mainboard/hp/z220_sff_workstation/romstage.c index 0804dd0..9883879 100644 --- a/src/mainboard/hp/z220_sff_workstation/romstage.c +++ b/src/mainboard/hp/z220_sff_workstation/romstage.c @@ -17,7 +17,6 @@ */
#include <stdint.h> -#include <arch/byteorder.h> #include <arch/io.h> #include <device/pci_ops.h> #include <device/pci_def.h> diff --git a/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c b/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c index 2396505..edb5894 100644 --- a/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c +++ b/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h> #include <fsp/api.h> diff --git a/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c b/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c index dd209dc..0c2f747 100644 --- a/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c +++ b/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <stdint.h> #include <string.h>
diff --git a/src/mainboard/intel/harcuvar/spd/spd.c b/src/mainboard/intel/harcuvar/spd/spd.c index 914e4fd..61bf2e5 100644 --- a/src/mainboard/intel/harcuvar/spd/spd.c +++ b/src/mainboard/intel/harcuvar/spd/spd.c @@ -15,7 +15,6 @@ * */
-#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h>
diff --git a/src/mainboard/intel/icelake_rvp/romstage_fsp_params.c b/src/mainboard/intel/icelake_rvp/romstage_fsp_params.c index fd1638b..5a4d681 100644 --- a/src/mainboard/intel/icelake_rvp/romstage_fsp_params.c +++ b/src/mainboard/intel/icelake_rvp/romstage_fsp_params.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <console/console.h> #include <fsp/api.h> #include <soc/romstage.h> diff --git a/src/mainboard/intel/icelake_rvp/spd/spd_util.c b/src/mainboard/intel/icelake_rvp/spd/spd_util.c index 8d7eaf6..d7babbd 100644 --- a/src/mainboard/intel/icelake_rvp/spd/spd_util.c +++ b/src/mainboard/intel/icelake_rvp/spd/spd_util.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <arch/cpu.h> #include <intelblocks/mp_init.h> #include <stdint.h> diff --git a/src/mainboard/intel/kblrvp/romstage.c b/src/mainboard/intel/kblrvp/romstage.c index 1a483bd..0385e29 100644 --- a/src/mainboard/intel/kblrvp/romstage.c +++ b/src/mainboard/intel/kblrvp/romstage.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h> #include <fsp/api.h> diff --git a/src/mainboard/intel/kblrvp/spd/spd_util.c b/src/mainboard/intel/kblrvp/spd/spd_util.c index f22dcaa..9318c39 100644 --- a/src/mainboard/intel/kblrvp/spd/spd_util.c +++ b/src/mainboard/intel/kblrvp/spd/spd_util.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <stdint.h> #include <string.h>
diff --git a/src/mainboard/intel/kunimitsu/romstage_fsp20.c b/src/mainboard/intel/kunimitsu/romstage_fsp20.c index ee1ddd5..5364693 100644 --- a/src/mainboard/intel/kunimitsu/romstage_fsp20.c +++ b/src/mainboard/intel/kunimitsu/romstage_fsp20.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <fsp/api.h> #include <gpio.h> #include "gpio.h" diff --git a/src/mainboard/intel/kunimitsu/spd/spd.c b/src/mainboard/intel/kunimitsu/spd/spd.c index bebb544..db5e24e 100644 --- a/src/mainboard/intel/kunimitsu/spd/spd.c +++ b/src/mainboard/intel/kunimitsu/spd/spd.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <console/console.h> #include <fsp/soc_binding.h> #include <soc/romstage.h> diff --git a/src/mainboard/intel/kunimitsu/spd/spd_util.c b/src/mainboard/intel/kunimitsu/spd/spd_util.c index b173628..288ee1e 100644 --- a/src/mainboard/intel/kunimitsu/spd/spd_util.c +++ b/src/mainboard/intel/kunimitsu/spd/spd_util.c @@ -12,7 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ -#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h> #include <stdint.h> diff --git a/src/mainboard/sapphire/pureplatinumh61/romstage.c b/src/mainboard/sapphire/pureplatinumh61/romstage.c index 296e896..9a67ab2 100644 --- a/src/mainboard/sapphire/pureplatinumh61/romstage.c +++ b/src/mainboard/sapphire/pureplatinumh61/romstage.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <arch/byteorder.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <northbridge/intel/sandybridge/sandybridge.h>
Hello Angel Pons, Arthur Heymans, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33537
to look at the new patch set (#2).
Change subject: src/mainboard: Remove unused include <arch/byteorder.h> ......................................................................
src/mainboard: Remove unused include <arch/byteorder.h>
Change-Id: I3d638febddbd88cd4870795f96dd1bbf123c7ba3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbookair4_2/romstage.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/hp/compaq_8200_elite_sff/romstage.c M src/mainboard/hp/z220_sff_workstation/romstage.c M src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c M src/mainboard/intel/cannonlake_rvp/spd/spd_util.c M src/mainboard/intel/harcuvar/spd/spd.c M src/mainboard/intel/icelake_rvp/romstage_fsp_params.c M src/mainboard/intel/icelake_rvp/spd/spd_util.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd_util.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/kunimitsu/spd/spd.c M src/mainboard/intel/kunimitsu/spd/spd_util.c M src/mainboard/sapphire/pureplatinumh61/romstage.c 16 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/33537/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33537 )
Change subject: src/mainboard: Remove unused include <arch/byteorder.h> ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33537 )
Change subject: src/mainboard: Remove unused include <arch/byteorder.h> ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33537 )
Change subject: src/mainboard: Remove unused include <arch/byteorder.h> ......................................................................
src/mainboard: Remove unused include <arch/byteorder.h>
Change-Id: I3d638febddbd88cd4870795f96dd1bbf123c7ba3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33537 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/apple/macbookair4_2/romstage.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/hp/compaq_8200_elite_sff/romstage.c M src/mainboard/hp/z220_sff_workstation/romstage.c M src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c M src/mainboard/intel/cannonlake_rvp/spd/spd_util.c M src/mainboard/intel/harcuvar/spd/spd.c M src/mainboard/intel/icelake_rvp/romstage_fsp_params.c M src/mainboard/intel/icelake_rvp/spd/spd_util.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd_util.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/kunimitsu/spd/spd.c M src/mainboard/intel/kunimitsu/spd/spd_util.c M src/mainboard/sapphire/pureplatinumh61/romstage.c 16 files changed, 0 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/apple/macbookair4_2/romstage.c b/src/mainboard/apple/macbookair4_2/romstage.c index 68556d9..6fee17a 100644 --- a/src/mainboard/apple/macbookair4_2/romstage.c +++ b/src/mainboard/apple/macbookair4_2/romstage.c @@ -13,7 +13,6 @@
#include <stdint.h> #include <string.h> -#include <arch/byteorder.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <northbridge/intel/sandybridge/sandybridge.h> diff --git a/src/mainboard/google/eve/spd/spd.c b/src/mainboard/google/eve/spd/spd.c index 077bed4..fca670c 100644 --- a/src/mainboard/google/eve/spd/spd.c +++ b/src/mainboard/google/eve/spd/spd.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h> #include <gpio.h> diff --git a/src/mainboard/google/glados/spd/spd.c b/src/mainboard/google/glados/spd/spd.c index b3cf3f9..9503582 100644 --- a/src/mainboard/google/glados/spd/spd.c +++ b/src/mainboard/google/glados/spd/spd.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h> #include <gpio.h> diff --git a/src/mainboard/hp/compaq_8200_elite_sff/romstage.c b/src/mainboard/hp/compaq_8200_elite_sff/romstage.c index 4b64068..3c38877 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/romstage.c +++ b/src/mainboard/hp/compaq_8200_elite_sff/romstage.c @@ -17,7 +17,6 @@ */
#include <stdint.h> -#include <arch/byteorder.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <superio/nuvoton/npcd378/npcd378.h> diff --git a/src/mainboard/hp/z220_sff_workstation/romstage.c b/src/mainboard/hp/z220_sff_workstation/romstage.c index 0804dd0..9883879 100644 --- a/src/mainboard/hp/z220_sff_workstation/romstage.c +++ b/src/mainboard/hp/z220_sff_workstation/romstage.c @@ -17,7 +17,6 @@ */
#include <stdint.h> -#include <arch/byteorder.h> #include <arch/io.h> #include <device/pci_ops.h> #include <device/pci_def.h> diff --git a/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c b/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c index 2396505..edb5894 100644 --- a/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c +++ b/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h> #include <fsp/api.h> diff --git a/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c b/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c index dd209dc..0c2f747 100644 --- a/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c +++ b/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <stdint.h> #include <string.h>
diff --git a/src/mainboard/intel/harcuvar/spd/spd.c b/src/mainboard/intel/harcuvar/spd/spd.c index 914e4fd..61bf2e5 100644 --- a/src/mainboard/intel/harcuvar/spd/spd.c +++ b/src/mainboard/intel/harcuvar/spd/spd.c @@ -15,7 +15,6 @@ * */
-#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h>
diff --git a/src/mainboard/intel/icelake_rvp/romstage_fsp_params.c b/src/mainboard/intel/icelake_rvp/romstage_fsp_params.c index fd1638b..5a4d681 100644 --- a/src/mainboard/intel/icelake_rvp/romstage_fsp_params.c +++ b/src/mainboard/intel/icelake_rvp/romstage_fsp_params.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <console/console.h> #include <fsp/api.h> #include <soc/romstage.h> diff --git a/src/mainboard/intel/icelake_rvp/spd/spd_util.c b/src/mainboard/intel/icelake_rvp/spd/spd_util.c index 8d7eaf6..d7babbd 100644 --- a/src/mainboard/intel/icelake_rvp/spd/spd_util.c +++ b/src/mainboard/intel/icelake_rvp/spd/spd_util.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <arch/cpu.h> #include <intelblocks/mp_init.h> #include <stdint.h> diff --git a/src/mainboard/intel/kblrvp/romstage.c b/src/mainboard/intel/kblrvp/romstage.c index 1a483bd..0385e29 100644 --- a/src/mainboard/intel/kblrvp/romstage.c +++ b/src/mainboard/intel/kblrvp/romstage.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h> #include <fsp/api.h> diff --git a/src/mainboard/intel/kblrvp/spd/spd_util.c b/src/mainboard/intel/kblrvp/spd/spd_util.c index f22dcaa..9318c39 100644 --- a/src/mainboard/intel/kblrvp/spd/spd_util.c +++ b/src/mainboard/intel/kblrvp/spd/spd_util.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <stdint.h> #include <string.h>
diff --git a/src/mainboard/intel/kunimitsu/romstage_fsp20.c b/src/mainboard/intel/kunimitsu/romstage_fsp20.c index ee1ddd5..5364693 100644 --- a/src/mainboard/intel/kunimitsu/romstage_fsp20.c +++ b/src/mainboard/intel/kunimitsu/romstage_fsp20.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <fsp/api.h> #include <gpio.h> #include "gpio.h" diff --git a/src/mainboard/intel/kunimitsu/spd/spd.c b/src/mainboard/intel/kunimitsu/spd/spd.c index bebb544..db5e24e 100644 --- a/src/mainboard/intel/kunimitsu/spd/spd.c +++ b/src/mainboard/intel/kunimitsu/spd/spd.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <arch/byteorder.h> #include <console/console.h> #include <fsp/soc_binding.h> #include <soc/romstage.h> diff --git a/src/mainboard/intel/kunimitsu/spd/spd_util.c b/src/mainboard/intel/kunimitsu/spd/spd_util.c index b173628..288ee1e 100644 --- a/src/mainboard/intel/kunimitsu/spd/spd_util.c +++ b/src/mainboard/intel/kunimitsu/spd/spd_util.c @@ -12,7 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ -#include <arch/byteorder.h> #include <cbfs.h> #include <console/console.h> #include <stdint.h> diff --git a/src/mainboard/sapphire/pureplatinumh61/romstage.c b/src/mainboard/sapphire/pureplatinumh61/romstage.c index 296e896..9a67ab2 100644 --- a/src/mainboard/sapphire/pureplatinumh61/romstage.c +++ b/src/mainboard/sapphire/pureplatinumh61/romstage.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <arch/byteorder.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <northbridge/intel/sandybridge/sandybridge.h>
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)