Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40483 )
Change subject: superio/aspeed/common: Add early configure functions
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40483/5/src/superio/aspeed/common/a...
File src/superio/aspeed/common/aspeed.h:
https://review.coreboot.org/c/coreboot/+/40483/5/src/superio/aspeed/common/a...
PS5, Line 11: #define ASPEED_MEM_BASE1 0x1E6E0000
Alignement
https://review.coreboot.org/c/coreboot/+/40483/5/src/superio/aspeed/common/a...
PS5, Line 25: #define ASPEED_MEM_BASE2 0x1E780000
Alignment
https://review.coreboot.org/c/coreboot/+/40483/5/src/superio/aspeed/common/a...
PS5, Line 45: #define PRO_KEY_PASSWORD 0x1688A8A8
Same here. Please fix the whole file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40483
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib59c29a042b2c7bf196b8a5bd5218704d8075855
Gerrit-Change-Number: 40483
Gerrit-PatchSet: 5
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Apr 2020 09:54:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment