Change in coreboot[master]: soc/amd/common/block/i2c/i23c_pad_ctrl: invert and mask

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63222 )

Change subject: soc/amd/common/block/i2c/i23c_pad_ctrl: invert and mask
......................................................................

soc/amd/common/block/i2c/i23c_pad_ctrl: invert and mask

When masking out bits with an and mask, the bit mask needs to be
inverted.

Signed-off-by: Felix Held 
Change-Id: I9739d7150e230fbbe6523413de9c07d7340f3c61
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63222
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: Fred Reitberger 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/common/block/i2c/i23c_pad_ctrl.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Karthik Ramasubramanian: Looks good to me, approved
  Fred Reitberger: Looks good to me, but someone else must approve

diff --git a/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c b/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c
index 36211a3..2439054 100644
--- a/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c
+++ b/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c
@@ -48,7 +48,7 @@
    pad_ctrl |= speed == I2C_SPEED_STANDARD ?
    	I23C_PAD_CTRL_FALLSLEW_SEL_STD : I23C_PAD_CTRL_FALLSLEW_SEL_LOW;

-	pad_ctrl &= I23C_PAD_CTRL_SLEW_N_MASK;
+	pad_ctrl &= ~I23C_PAD_CTRL_SLEW_N_MASK;
    pad_ctrl |= I23C_PAD_CTRL_SLEW_N_FAST;

misc_write32(MISC_I23C_PAD_CTRL(bus), pad_ctrl);