Attention is currently required from: Christian Walter, Arthur Heymans, Michael Niewöhner, Shawn C.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F
......................................................................
Patch Set 70:
(3 comments)
Patchset:
PS70:
Hi, I've tested it on x11sch-f with a TPMv2 chip (9670H) but found a reproducible bug: […]
Did you patch the IFD as described here? https://review.coreboot.org/c/coreboot/+/37441/64..70/Documentation/mainboar...
File src/mainboard/supermicro/x11-lga1151v2-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37441/comment/aa44a535_606c4886
PS67, Line 12: # SPS doesn't support all commands issued by FSP
Well, same would apply for X11SSM-F, where disabling this isn't needed. Hmm...
Well, it's not required, but saves some time
File src/mainboard/supermicro/x11-lga1151v2-series/variants/x11sch-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37441/comment/1ce5bdbe_e09e6a2d
PS67, Line 87: smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther"
: "M.2-P_1" "SlotDataBusWidth4X"
:
Ah, that looks good. I was misleaded by having this in mind: […]
I have no clue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37441
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ab1cb9462607b9af068bc2374508d99c60d0a30
Gerrit-Change-Number: 37441
Gerrit-PatchSet: 70
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies
guido.beyer@prodrive-technologies.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stef van Os
stef.van.os@prodrive-technologies.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-CC: Jonas Löffelholz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Shawn C
citypw@hardenedlinux.org
Gerrit-Comment-Date: Fri, 15 Oct 2021 11:01:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Shawn C
citypw@hardenedlinux.org
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment