Change in coreboot[master]: mb/google/drallion: Add detect pin for Wacom touchscreen

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: build:...

Frank Wu (Code Review)

4 Oct 2019 4 Oct '19

9:16 a.m.

Frank Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35790 )

Change subject: mb/google/drallion: Add detect pin for Wacom touchscreen ......................................................................

mb/google/drallion: Add detect pin for Wacom touchscreen

Add the missing detect pin to fix Wacom touchscreen function

BUG=b:140415892,b:138082886 BRANCH=N/A TEST=N/A

Change-Id: I8a1b48d4d502945b88e38393383512d30b684fa4 Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/35790/1

diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index db3f36b..1f628d6 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -329,6 +329,8 @@ register "generic.has_power_resource" = "1" register "generic.disable_gpio_export_in_crs" = "1" register "hid_desc_reg_offset" = "0x1" + register "generic.device_present_gpio" = "GPP_B4" + register "generic.device_present_gpio_invert" = "1" device i2c 0A on end end chip drivers/i2c/hid

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

EricR Lai (Code Review)

4 Oct 4 Oct

10:38 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35790 )

Change subject: mb/google/drallion: Add detect pin for Wacom touchscreen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35790/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35790/1//COMMIT_MSG@9 PS1, Line 9: Add the missing detect pin to fix Wacom touchscreen function put . in the end

-- To view, visit https://review.coreboot.org/c/coreboot/+/35790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8a1b48d4d502945b88e38393383512d30b684fa4 Gerrit-Change-Number: 35790 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Bernardo Perez Priego bernardo.perez.priego@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 04 Oct 2019 10:38:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frank Wu (Code Review)

5 Oct 5 Oct

2:37 a.m.

Hello Thejaswani Putta, EricR Lai, Aamir Bohra, Bernardo Perez Priego, Mathew King, Selma Bensaid, Duncan Laurie, Bora Guvendik, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35790

to look at the new patch set (#2).

Change subject: mb/google/drallion: Add detect pin for Wacom touchscreen ......................................................................

mb/google/drallion: Add detect pin for Wacom touchscreen

Add the missing detect pin to fix Wacom touchscreen function.

BUG=b:140415892,b:138082886 BRANCH=N/A TEST=N/A

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/35790/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8a1b48d4d502945b88e38393383512d30b684fa4 Gerrit-Change-Number: 35790 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Bernardo Perez Priego bernardo.perez.priego@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Frank Wu (Code Review)

2:37 a.m.

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35790 )

Change subject: mb/google/drallion: Add detect pin for Wacom touchscreen ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35790/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35790/1//COMMIT_MSG@9 PS1, Line 9: Add the missing detect pin to fix Wacom touchscreen function

...

put . […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8a1b48d4d502945b88e38393383512d30b684fa4 Gerrit-Change-Number: 35790 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Bernardo Perez Priego bernardo.perez.priego@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 05 Oct 2019 02:37:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-MessageType: comment

EricR Lai (Code Review)

4:45 p.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35790 )

Change subject: mb/google/drallion: Add detect pin for Wacom touchscreen ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8a1b48d4d502945b88e38393383512d30b684fa4 Gerrit-Change-Number: 35790 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Bernardo Perez Priego bernardo.perez.priego@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 05 Oct 2019 16:45:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Werner Zeh (Code Review)

8 Oct 8 Oct

5:53 a.m.

Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35790 )

Change subject: mb/google/drallion: Add detect pin for Wacom touchscreen ......................................................................

mb/google/drallion: Add detect pin for Wacom touchscreen

Add the missing detect pin to fix Wacom touchscreen function.

BUG=b:140415892,b:138082886 BRANCH=N/A TEST=N/A

Change-Id: I8a1b48d4d502945b88e38393383512d30b684fa4 Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35790 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/35790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8a1b48d4d502945b88e38393383512d30b684fa4 Gerrit-Change-Number: 35790 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Bernardo Perez Priego bernardo.perez.priego@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1877

days inactive

1881

days old

coreboot-gerrit@coreboot.org

5 comments

3 participants

tags (0)

participants (3)

EricR Lai (Code Review)
Frank Wu (Code Review)
Werner Zeh (Code Review)