23 May
2019
23 May
'19
6:03 p.m.
SANTHOSH JANARDHANA HASSAN has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29949 )
Change subject: mainboard/google/mistral: Add support for Mistral ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/#/c/29949/14/src/mainboard/google/mistral/chrome... File src/mainboard/google/mistral/chromeos.fmd:
https://review.coreboot.org/#/c/29949/14/src/mainboard/google/mistral/chrome... PS14, Line 25: RO_VPD 128K Add PRESERVE flag.Without this VPD data is lost if firmware is updated with this CL. Raise CL to fix this ASAP.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ecfad68bb50f42acf36f51bc3433add56597c3d
Gerrit-Change-Number: 29949
Gerrit-PatchSet: 14
Gerrit-Owner: Nitheesh Sekar nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: SANTHOSH JANARDHANA HASSAN sahassan@google.com
Gerrit-CC: Sricharan Ramabadhran srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 23 May 2019 16:03:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
2176
days inactive
2176
days old
0 comments
1 participants
participants (1)
-
SANTHOSH JANARDHANA HASSAN (Code Review)