Name of user not set #1003174 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47056 )
Change subject: Support for Zotac AD04 added (initial commit) ......................................................................
Support for Zotac AD04 added (initial commit)
Signed-off-by: moscovium-115 3134c487@tutanota.com Change-Id: I184fb55b184c7739824d801524e2a3d1d2573f11 --- A Documentation/mainboard/zotac/ad04/ad04.md A Documentation/mainboard/zotac/ad04/logs/acpidump.err.log A Documentation/mainboard/zotac/ad04/logs/acpidump.log A Documentation/mainboard/zotac/ad04/logs/biosdecode.err.log A Documentation/mainboard/zotac/ad04/logs/biosdecode.log A Documentation/mainboard/zotac/ad04/logs/codec#0 A Documentation/mainboard/zotac/ad04/logs/cpuinfo.err.log A Documentation/mainboard/zotac/ad04/logs/cpuinfo.log A Documentation/mainboard/zotac/ad04/logs/dmesg.err.log A Documentation/mainboard/zotac/ad04/logs/dmesg.log A Documentation/mainboard/zotac/ad04/logs/dmidecode.err.log A Documentation/mainboard/zotac/ad04/logs/dmidecode.log A Documentation/mainboard/zotac/ad04/logs/ectool.err.log A Documentation/mainboard/zotac/ad04/logs/ectool.log A Documentation/mainboard/zotac/ad04/logs/flashrom_info.err.log A Documentation/mainboard/zotac/ad04/logs/flashrom_info.log A Documentation/mainboard/zotac/ad04/logs/flashrom_read.err.log A Documentation/mainboard/zotac/ad04/logs/flashrom_read.log A Documentation/mainboard/zotac/ad04/logs/input_bustypes.log A Documentation/mainboard/zotac/ad04/logs/inteltool.err.log A Documentation/mainboard/zotac/ad04/logs/inteltool.log A Documentation/mainboard/zotac/ad04/logs/ioports.err.log A Documentation/mainboard/zotac/ad04/logs/ioports.log A Documentation/mainboard/zotac/ad04/logs/log.sh A Documentation/mainboard/zotac/ad04/logs/lspci.err.log A Documentation/mainboard/zotac/ad04/logs/lspci.log A Documentation/mainboard/zotac/ad04/logs/lsusb.err.log A Documentation/mainboard/zotac/ad04/logs/lsusb.log A Documentation/mainboard/zotac/ad04/logs/msrtool.err.log A Documentation/mainboard/zotac/ad04/logs/msrtool.log A Documentation/mainboard/zotac/ad04/logs/nvramtool.err.log A Documentation/mainboard/zotac/ad04/logs/nvramtool.log A Documentation/mainboard/zotac/ad04/logs/pin_hwC0D0 A Documentation/mainboard/zotac/ad04/logs/rom.bin A Documentation/mainboard/zotac/ad04/logs/superiotool.err.log A Documentation/mainboard/zotac/ad04/logs/superiotool.log A configs/config.zotac_ad04 A src/mainboard/zotac/Kconfig A src/mainboard/zotac/Kconfig.name A src/mainboard/zotac/ad04/BiosCallOuts.c A src/mainboard/zotac/ad04/Kconfig A src/mainboard/zotac/ad04/Kconfig.name A src/mainboard/zotac/ad04/Makefile.inc A src/mainboard/zotac/ad04/OemCustomize.c A src/mainboard/zotac/ad04/OptionsIds.h A src/mainboard/zotac/ad04/acpi/buttons.asl A src/mainboard/zotac/ad04/acpi/gpe.asl A src/mainboard/zotac/ad04/acpi/gpio.asl A src/mainboard/zotac/ad04/acpi/leds.asl A src/mainboard/zotac/ad04/acpi/mainboard.asl A src/mainboard/zotac/ad04/acpi/routing.asl A src/mainboard/zotac/ad04/acpi/sata.asl A src/mainboard/zotac/ad04/acpi/sleep.asl A src/mainboard/zotac/ad04/acpi/superio.asl A src/mainboard/zotac/ad04/acpi/usb_oc.asl A src/mainboard/zotac/ad04/acpi_tables.c A src/mainboard/zotac/ad04/board_info.txt A src/mainboard/zotac/ad04/bootblock.c A src/mainboard/zotac/ad04/buildOpts.c A src/mainboard/zotac/ad04/cmos.default A src/mainboard/zotac/ad04/cmos.layout A src/mainboard/zotac/ad04/devicetree.cb A src/mainboard/zotac/ad04/dsdt.asl A src/mainboard/zotac/ad04/gpio_ftns.c A src/mainboard/zotac/ad04/gpio_ftns.h A src/mainboard/zotac/ad04/irq_tables.c A src/mainboard/zotac/ad04/mainboard.c A src/mainboard/zotac/ad04/mptable.c A src/mainboard/zotac/ad04/platform_cfg.h A src/mainboard/zotac/ad04/romstage.c A src/mainboard/zotac/ad04/spd/HYNIX-H5TQ2G83CFR.spd.hex A src/mainboard/zotac/ad04/spd/HYNIX-H5TQ4G83MFR.spd.hex 72 files changed, 17,792 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/47056/1
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47056 )
Change subject: Support for Zotac AD04 added (initial commit) ......................................................................
Patch Set 1:
(103 comments)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... File src/mainboard/zotac/ad04/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... PS1, Line 11: static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... PS1, Line 11: static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr); need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... PS1, Line 15: { that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... PS1, Line 29: static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... PS1, Line 33: ((MEM_DATA_STRUCT*)ConfigPtr)->ParameterListPtr->DDR3Voltage = VOLT1_5; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... PS1, Line 54: if (read_ddr3_spd_from_cbfs((u8*)info->Buffer, index) < 0) "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Oe... File src/mainboard/zotac/ad04/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Oe... PS1, Line 79: * Platform Specific Overriding Table allows IBV/OEM to pass in platform information to AGESA line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Oe... PS1, Line 80: * (e.g. MemClk routing, the number of DIMM slots per channel,...). If PlatformSpecificTable line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Oe... PS1, Line 81: * is populated, AGESA will base its settings on the data from the table. Otherwise, it will line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Oe... PS1, Line 95: WRITE_LEVELING_SEED(ANY_SOCKET, ANY_CHANNEL, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED), line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Oe... PS1, Line 96: HW_RXEN_SEED(ANY_SOCKET, ANY_CHANNEL, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED), line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ir... File src/mainboard/zotac/ad04/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ir... PS1, Line 81: if (sum != pirq->checksum) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... File src/mainboard/zotac/ad04/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 49: [0x40] = 0x0B,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 51: [0x50] = 0x0A,0x0B,0x0A,0x0B space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 51: [0x50] = 0x0A,0x0B,0x0A,0x0B space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 51: [0x50] = 0x0A,0x0B,0x0A,0x0B space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 66: [0x40] = 0x11,0x13, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 68: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 68: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 68: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 90: {GFX_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* VGA: 01.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 91: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* NIC: 04.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 92: {NB_PCIE_PORT2_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* NIC: 05.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 93: {NB_PCIE_PORT3_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* NIC: 06.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 94: {NB_PCIE_PORT4_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* miniPCIe: 07.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 95: {SATA_DEVFN, {PIRQ_SATA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* SATA: 11.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 96: {OHCI1_DEVFN, {PIRQ_OHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI1: 12.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 97: {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC}}, /* EHCI1: 12.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 98: {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI2: 13.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 99: {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC}}, /* EHCI2: 13.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 100: {SMBUS_DEVFN, {PIRQ_SMBUS, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* SMBUS: 14.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 101: {IDE_DEVFN, {PIRQ_NC, PIRQ_IDE, PIRQ_NC, PIRQ_NC}}, /* IDE: 14.1 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 102: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* HDA: 14.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 103: {SB_PCI_PORT_DEVFN, {PIRQ_H, PIRQ_E, PIRQ_F, PIRQ_G}}, /* PCI bdg: 14.4 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 104: {OHCI4_DEVFN, {PIRQ_NC, PIRQ_NC, PIRQ_OHCI4, PIRQ_NC}}, /* OHCI4: 14.5 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 105: {SB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* miniPCIe: 15.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 106: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ma... PS1, Line 107: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/mp... File src/mainboard/zotac/ad04/mptable.c:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/mp... PS1, Line 59: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(fn)), ioapic_id, (pin)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/mp... PS1, Line 103: #define IO_LOCAL_INT(type, intr, apicid, pin) \ macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/mp... PS1, Line 104: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)); line over 96 characters
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47056 )
Change subject: Support for Zotac AD04 added (initial commit) ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... File src/mainboard/zotac/ad04/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... PS1, Line 37: static AGESA_STATUS board_ReadSpd_from_cbfs(UINT32 Func, UINTN Data, VOID *ConfigPtr) : { : AGESA_READ_SPD_PARAMS *info = ConfigPtr; : : if (!ENV_ROMSTAGE) : return AGESA_UNSUPPORTED; : : u8 index = get_spd_offset(); : : if (info->MemChannelId > 0) : return AGESA_UNSUPPORTED; : if (info->SocketId != 0) : return AGESA_UNSUPPORTED; : if (info->DimmId != 0) : return AGESA_UNSUPPORTED; : : /* Read index 0, first SPD_SIZE bytes of spd.bin file. */ : if (read_ddr3_spd_from_cbfs((u8*)info->Buffer, index) < 0) : die("No SPD data\n"); : : return AGESA_SUCCESS; : } You probably want to do what e350m1 does here instead
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Kc... File src/mainboard/zotac/ad04/Kconfig:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Kc... PS1, Line 20: select MAINBOARD_HAS_LPC_TPM I don't think this board has a TPM?
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Kc... PS1, Line 28: apu1 nope
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Kc... PS1, Line 63: choice : prompt "J19 pins 1-10" : default APU1_PINMUX_OFF_C : : config APU1_PINMUX_OFF_C : bool "disable" : : config APU1_PINMUX_GPIO0 : bool "GPIO" : : config APU1_PINMUX_UART_C : bool "UART 0x3e8" : : endchoice : : config UART_C_RS485 : bool "UART C drives RTS# in RS485 mode" if APU1_PINMUX_UART_C : : choice : prompt "J19 pins 11-20" : default APU1_PINMUX_OFF_D : : config APU1_PINMUX_OFF_D : bool "disable" : : config APU1_PINMUX_GPIO1 : bool "GPIO" : : config APU1_PINMUX_UART_D : bool "UART 0x2e8" : : endchoice : : config UART_D_RS485 : bool "UART D drives RTS# in RS485 mode" if APU1_PINMUX_UART_D Remove these and any board code using these options
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/gp... File src/mainboard/zotac/ad04/gpio_ftns.c:
PS1: This shouldn't be needed.
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ro... File src/mainboard/zotac/ad04/romstage.c:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ro... PS1, Line 20: /* Multi-function pins switch to GPIO0-35, these pins are shared with PCI pins */ : bdata = pm_read8(SB_PMIOA_REGEA); : bdata &= 0xfe; //clear bit 0 : bdata |= 0x01; //set bit 0 : pm_write8(SB_PMIOA_REGEA, bdata); : : //configure required GPIOs : configure_gpio(GPIO_10, GPIO_FTN_1, GPIO_OUTPUT | GPIO_DATA_HIGH); : configure_gpio(GPIO_11, GPIO_FTN_1, GPIO_OUTPUT | GPIO_DATA_HIGH); : configure_gpio(GPIO_15, GPIO_FTN_1, GPIO_INPUT); : configure_gpio(GPIO_16, GPIO_FTN_1, GPIO_INPUT); : configure_gpio(GPIO_17, GPIO_FTN_1, GPIO_INPUT); : configure_gpio(GPIO_18, GPIO_FTN_1, GPIO_INPUT); : configure_gpio(GPIO_187, GPIO_FTN_1, GPIO_INPUT); : configure_gpio(GPIO_189, GPIO_FTN_1, GPIO_OUTPUT | GPIO_DATA_LOW); : configure_gpio(GPIO_190, GPIO_FTN_1, GPIO_OUTPUT | GPIO_DATA_LOW); : configure_gpio(GPIO_191, GPIO_FTN_1, GPIO_OUTPUT | GPIO_DATA_LOW); This can be skipped for now
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/sp... File src/mainboard/zotac/ad04/spd/HYNIX-H5TQ2G83CFR.spd.hex:
PS1: No onboard memory, this can be removed
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47056 )
Change subject: Support for Zotac AD04 added (initial commit) ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... File src/mainboard/zotac/ad04/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... PS1, Line 37: static AGESA_STATUS board_ReadSpd_from_cbfs(UINT32 Func, UINTN Data, VOID *ConfigPtr) : { : AGESA_READ_SPD_PARAMS *info = ConfigPtr; : : if (!ENV_ROMSTAGE) : return AGESA_UNSUPPORTED; : : u8 index = get_spd_offset(); : : if (info->MemChannelId > 0) : return AGESA_UNSUPPORTED; : if (info->SocketId != 0) : return AGESA_UNSUPPORTED; : if (info->DimmId != 0) : return AGESA_UNSUPPORTED; : : /* Read index 0, first SPD_SIZE bytes of spd.bin file. */ : if (read_ddr3_spd_from_cbfs((u8*)info->Buffer, index) < 0) : die("No SPD data\n"); : : return AGESA_SUCCESS; : }
You probably want to do what e350m1 does here instead
mb/asrock/e350m1, that is. Basically, use `agesa_ReadSpd` for the AGESA_READ_SPD callback.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47056 )
Change subject: Support for Zotac AD04 added (initial commit) ......................................................................
Patch Set 2:
(103 comments)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Bi... File src/mainboard/zotac/ad04/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Bi... PS2, Line 11: static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Bi... PS2, Line 11: static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr); need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Bi... PS2, Line 15: { that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Bi... PS2, Line 29: static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Bi... PS2, Line 33: ((MEM_DATA_STRUCT*)ConfigPtr)->ParameterListPtr->DDR3Voltage = VOLT1_5; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Bi... PS2, Line 54: if (read_ddr3_spd_from_cbfs((u8*)info->Buffer, index) < 0) "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Oe... File src/mainboard/zotac/ad04/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Oe... PS2, Line 79: * Platform Specific Overriding Table allows IBV/OEM to pass in platform information to AGESA line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Oe... PS2, Line 80: * (e.g. MemClk routing, the number of DIMM slots per channel,...). If PlatformSpecificTable line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Oe... PS2, Line 81: * is populated, AGESA will base its settings on the data from the table. Otherwise, it will line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Oe... PS2, Line 95: WRITE_LEVELING_SEED(ANY_SOCKET, ANY_CHANNEL, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED), line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/Oe... PS2, Line 96: HW_RXEN_SEED(ANY_SOCKET, ANY_CHANNEL, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED), line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ir... File src/mainboard/zotac/ad04/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ir... PS2, Line 81: if (sum != pirq->checksum) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... File src/mainboard/zotac/ad04/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 49: [0x40] = 0x0B,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 51: [0x50] = 0x0A,0x0B,0x0A,0x0B space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 51: [0x50] = 0x0A,0x0B,0x0A,0x0B space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 51: [0x50] = 0x0A,0x0B,0x0A,0x0B space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 66: [0x40] = 0x11,0x13, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 68: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 68: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 68: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 90: {GFX_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* VGA: 01.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 91: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* NIC: 04.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 92: {NB_PCIE_PORT2_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* NIC: 05.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 93: {NB_PCIE_PORT3_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* NIC: 06.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 94: {NB_PCIE_PORT4_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* miniPCIe: 07.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 95: {SATA_DEVFN, {PIRQ_SATA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* SATA: 11.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 96: {OHCI1_DEVFN, {PIRQ_OHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI1: 12.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 97: {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC}}, /* EHCI1: 12.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 98: {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI2: 13.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 99: {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC}}, /* EHCI2: 13.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 100: {SMBUS_DEVFN, {PIRQ_SMBUS, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* SMBUS: 14.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 101: {IDE_DEVFN, {PIRQ_NC, PIRQ_IDE, PIRQ_NC, PIRQ_NC}}, /* IDE: 14.1 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 102: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* HDA: 14.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 103: {SB_PCI_PORT_DEVFN, {PIRQ_H, PIRQ_E, PIRQ_F, PIRQ_G}}, /* PCI bdg: 14.4 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 104: {OHCI4_DEVFN, {PIRQ_NC, PIRQ_NC, PIRQ_OHCI4, PIRQ_NC}}, /* OHCI4: 14.5 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 105: {SB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* miniPCIe: 15.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 106: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/ma... PS2, Line 107: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/mp... File src/mainboard/zotac/ad04/mptable.c:
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/mp... PS2, Line 59: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(fn)), ioapic_id, (pin)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/mp... PS2, Line 103: #define IO_LOCAL_INT(type, intr, apicid, pin) \ macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/47056/2/src/mainboard/zotac/ad04/mp... PS2, Line 104: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)); line over 96 characters
Name of user not set #1003174 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47056 )
Change subject: Support for Zotac AD04 added (initial commit) ......................................................................
Patch Set 2:
(7 comments)
Done and committed for review
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... File src/mainboard/zotac/ad04/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... PS1, Line 37: static AGESA_STATUS board_ReadSpd_from_cbfs(UINT32 Func, UINTN Data, VOID *ConfigPtr) : { : AGESA_READ_SPD_PARAMS *info = ConfigPtr; : : if (!ENV_ROMSTAGE) : return AGESA_UNSUPPORTED; : : u8 index = get_spd_offset(); : : if (info->MemChannelId > 0) : return AGESA_UNSUPPORTED; : if (info->SocketId != 0) : return AGESA_UNSUPPORTED; : if (info->DimmId != 0) : return AGESA_UNSUPPORTED; : : /* Read index 0, first SPD_SIZE bytes of spd.bin file. */ : if (read_ddr3_spd_from_cbfs((u8*)info->Buffer, index) < 0) : die("No SPD data\n"); : : return AGESA_SUCCESS; : }
mb/asrock/e350m1, that is. Basically, use `agesa_ReadSpd` for the AGESA_READ_SPD callback.
Done
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Kc... File src/mainboard/zotac/ad04/Kconfig:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Kc... PS1, Line 20: select MAINBOARD_HAS_LPC_TPM
I don't think this board has a TPM?
Done
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Kc... PS1, Line 28: apu1
nope
Done
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Kc... PS1, Line 63: choice : prompt "J19 pins 1-10" : default APU1_PINMUX_OFF_C : : config APU1_PINMUX_OFF_C : bool "disable" : : config APU1_PINMUX_GPIO0 : bool "GPIO" : : config APU1_PINMUX_UART_C : bool "UART 0x3e8" : : endchoice : : config UART_C_RS485 : bool "UART C drives RTS# in RS485 mode" if APU1_PINMUX_UART_C : : choice : prompt "J19 pins 11-20" : default APU1_PINMUX_OFF_D : : config APU1_PINMUX_OFF_D : bool "disable" : : config APU1_PINMUX_GPIO1 : bool "GPIO" : : config APU1_PINMUX_UART_D : bool "UART 0x2e8" : : endchoice : : config UART_D_RS485 : bool "UART D drives RTS# in RS485 mode" if APU1_PINMUX_UART_D
Remove these and any board code using these options
Done
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/gp... File src/mainboard/zotac/ad04/gpio_ftns.c:
PS1:
This shouldn't be needed.
not quite sure. get_spd_offset is required for smbios maximum capacity (mainboard/zotac/ad04/mainboard.c, arch/x86/smbios.c). what should this be replaced by?
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ro... File src/mainboard/zotac/ad04/romstage.c:
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/ro... PS1, Line 20: /* Multi-function pins switch to GPIO0-35, these pins are shared with PCI pins */ : bdata = pm_read8(SB_PMIOA_REGEA); : bdata &= 0xfe; //clear bit 0 : bdata |= 0x01; //set bit 0 : pm_write8(SB_PMIOA_REGEA, bdata); : : //configure required GPIOs : configure_gpio(GPIO_10, GPIO_FTN_1, GPIO_OUTPUT | GPIO_DATA_HIGH); : configure_gpio(GPIO_11, GPIO_FTN_1, GPIO_OUTPUT | GPIO_DATA_HIGH); : configure_gpio(GPIO_15, GPIO_FTN_1, GPIO_INPUT); : configure_gpio(GPIO_16, GPIO_FTN_1, GPIO_INPUT); : configure_gpio(GPIO_17, GPIO_FTN_1, GPIO_INPUT); : configure_gpio(GPIO_18, GPIO_FTN_1, GPIO_INPUT); : configure_gpio(GPIO_187, GPIO_FTN_1, GPIO_INPUT); : configure_gpio(GPIO_189, GPIO_FTN_1, GPIO_OUTPUT | GPIO_DATA_LOW); : configure_gpio(GPIO_190, GPIO_FTN_1, GPIO_OUTPUT | GPIO_DATA_LOW); : configure_gpio(GPIO_191, GPIO_FTN_1, GPIO_OUTPUT | GPIO_DATA_LOW);
This can be skipped for now
Done
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/sp... File src/mainboard/zotac/ad04/spd/HYNIX-H5TQ2G83CFR.spd.hex:
PS1:
No onboard memory, this can be removed
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47056 )
Change subject: Support for Zotac AD04 added (initial commit) ......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
(7 comments)
Done and committed for review
Okay, you can try to flash the result. Ensure you have a backup of the flash chip contents, just in case. If unsure how to proceed, feel free to ask around on IRC.
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/gp... File src/mainboard/zotac/ad04/gpio_ftns.c:
PS1:
not quite sure. […]
You can hardcode that value for now. Ideally, SMBIOS tables should be generated through chipset code, but AGESA platforms aren't in a great shape...
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47056?usp=email )
Change subject: Support for Zotac AD04 added (initial commit) ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Angel Pons (Code Review) -
build bot (Jenkins) (Code Review)
-
Martin L Roth (Code Review)
-
Name of user not set (Code Review)