Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31345
Change subject: siemens/mc_apl2: Remove double entry into devicetree ......................................................................
siemens/mc_apl2: Remove double entry into devicetree
Remove a double entry for LPC device in the devicetree.
Change-Id: Ib5b4f760251236d6a8b4aba719666daa97e7813d Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/31345/1
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb index 7a0b886..42c474e 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb @@ -105,7 +105,6 @@ device pci 1c.0 on end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO - device pci 1f.0 on end # - LPC device pci 1f.0 on # - LPC chip drivers/pc80/tpm device pnp 0c31.0 on end
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31345 )
Change subject: siemens/mc_apl2: Remove double entry into devicetree ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31345/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31345/1//COMMIT_MSG@7 PS1, Line 7: into from And just one whitespace please.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31345 )
Change subject: siemens/mc_apl2: Remove double entry into devicetree ......................................................................
Patch Set 1: Code-Review+2
Hello Kyösti Mälkki, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31345
to look at the new patch set (#2).
Change subject: siemens/mc_apl2: Remove double entry from devicetree ......................................................................
siemens/mc_apl2: Remove double entry from devicetree
Remove a double entry for LPC device from devicetree.
Change-Id: Ib5b4f760251236d6a8b4aba719666daa97e7813d Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/31345/2
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31345 )
Change subject: siemens/mc_apl2: Remove double entry from devicetree ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31345/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31345/1//COMMIT_MSG@7 PS1, Line 7: into
from […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31345 )
Change subject: siemens/mc_apl2: Remove double entry from devicetree ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31345 )
Change subject: siemens/mc_apl2: Remove double entry from devicetree ......................................................................
Patch Set 2: Code-Review+1
Werner Zeh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31345 )
Change subject: siemens/mc_apl2: Remove double entry from devicetree ......................................................................
siemens/mc_apl2: Remove double entry from devicetree
Remove a double entry for LPC device from devicetree.
Change-Id: Ib5b4f760251236d6a8b4aba719666daa97e7813d Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-on: https://review.coreboot.org/c/31345 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb index 7a0b886..42c474e 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb @@ -105,7 +105,6 @@ device pci 1c.0 on end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO - device pci 1f.0 on end # - LPC device pci 1f.0 on # - LPC chip drivers/pc80/tpm device pnp 0c31.0 on end
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Mario Scheithauer (Code Review)
-
Paul Menzel (Code Review)
-
Werner Zeh (Code Review)