Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27870 )
Change subject: cpu/intel/smm: Make sure SMRR base is aligned to SMRR size ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27870/2/src/cpu/intel/smm/gen1/smmrelocate.c File src/cpu/intel/smm/gen1/smmrelocate.c:
https://review.coreboot.org/#/c/27870/2/src/cpu/intel/smm/gen1/smmrelocate.c... PS2, Line 180: BIOS_WARNING
warning or error?
looking at the description of both, it feels like BIOS_WARNING is better since it is expected to still work if SMRR is not set. Not sure to what extend TSEG is accessible accessible with SMRR being set, so it is a security issue at most.