Attention is currently required from: Felix Singer, Hung-Te Lin, Julius Werner, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email )
Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/corsola/Kconfig:
https://review.coreboot.org/c/coreboot/+/79063/comment/085bd560_8e6847ac : PS1, Line 22: select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_CHINCHOU
Hmm... I think I find my version a bit clearer to be honest, but it's your board so happy to switch this to your proposal if you prefer. I think the way I wrote it makes it pretty straight-forward to read:
- All the Kinglers have ANX, except for Steelix which also has Parade in addition.
- All the Krabbies have Parade, except Chinchou which has ANX instead.
- All the Staryus have MIPI.
That looks clean because right now we only have one exception for Chinchou. As there's even no guarantee that "most Kinglers will have Parade" (that's entirely up to the OEM's choice), I think it's better to not view Chinchou as minority. That's also the reason why I decided to decouple Parade/ANX from Kingler/Krabby in the past. If there are more boards like Chinchou, then your version would look like:
``` config BOARD_GOOGLE_KRABBY_COMMON select DRIVER_ANALOGIX_ANX7625 if BOARD_A || BOARD_B || BOARD_C select DRIVER_PARADE_PS8640 if !(BOARD_A || BOARD_B || BOARD_C) # Or applying De Morgan's laws ```
which doesn't look clean to me. Therefore I think I still prefer
``` select DRIVER_ANALOGIX_ANX7625 if \ BOARD_GOOGLE_KINGLER_COMMON || BOARD_GOOGLE_CHINCHOU select DRIVER_PARADE_PS8640 if \ !(DRIVER_ANALOGIX_ANX7625 || BOARD_GOOGLE_STARYU_COMMON) || \ BOARD_GOOGLE_STEELIX ```
And if in the future things become more complicated (for example a Kingler with Parade), we can easily modify that to specify each board in the condition. Hung-Te/Yidi what's your opinion?
File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/79063/comment/6a988a2a_b444f2bb : PS1, Line 27: BOARD_GOOGLE_WILLOW
I did that by adding JACUZZI_COMMON to the def_bool list for KUKUI_COMMON above. […]
Acknowledged