Attention is currently required from: Nico Huber, Arthur Heymans, Alexander Couzens, Patrick Rudolph. Hello Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/55687
to review the following change.
Change subject: mb/lenovo/t440p: Disable second PEG device ......................................................................
mb/lenovo/t440p: Disable second PEG device
PEG bifurcation is strapped to x8/x8 on this board, but only the first port is used. Disable the PEG device at 00:01.1 because it is unused.
Should fix booting with commit ae999503f62ef8a3b9b2756a2810d29c383a009e (nb/intel/haswell/pcie.c: Add missing pre-ASPM init). The `config_of()` function call added in that commit makes coreboot die if any PEG device that is enabled by strapping is not present in the devicetree. While it is true that the PEG code should not use `config_of()`, this PEG device should still be disabled on this board as it is never used.
Change-Id: I16809e081f9a56ba2f1fdfcb4b8289d75161056b Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/lenovo/t440p/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/55687/1
diff --git a/src/mainboard/lenovo/t440p/devicetree.cb b/src/mainboard/lenovo/t440p/devicetree.cb index 1713387..b7588ea 100644 --- a/src/mainboard/lenovo/t440p/devicetree.cb +++ b/src/mainboard/lenovo/t440p/devicetree.cb @@ -24,6 +24,7 @@
device pci 00.0 on end # Host bridge device pci 01.0 on end # PCIe Bridge for discrete graphics + device pci 01.1 off end # Unused PCIe Bridge device pci 02.0 on end # Internal graphics VGA controller device pci 03.0 on end # Mini-HD audio