Attention is currently required from: Jason Glenesk, Raul Rangel, Matt Papageorge, Felix Held.
Julian Schroeder has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54065 )
Change subject: soc/amd/cezanne: adding support for the changed AMD FSP API for USB PHY
......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS7:
I ran the checkpatch tool. Should be ok now
File src/vendorcode/amd/fsp/cezanne/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/54065/comment/ecffbc12_6a0a9f20
PS6, Line 95: /** Offset 0x04D8**/ struct usb_phy_config *usb_phy;
should we just leave this as array of bytes and then cast to it later?
it's ugly either way. this all needs to be converted into a clean C structure
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I011ca40a334e4fd26778ca7f18b653298b14019b
Gerrit-Change-Number: 54065
Gerrit-PatchSet: 7
Gerrit-Owner: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 14 May 2021 12:43:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-MessageType: comment