Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81206?usp=email )
Change subject: ec/hp/kbc1126/acpi: Drop unnecessary _STA methods ......................................................................
ec/hp/kbc1126/acpi: Drop unnecessary _STA methods
_STA unconditionally returning 0xF is pretty much the default[1] and should be removed to reduce some noise.
[1] https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/06_Device_Configuration/Device...
Change-Id: I0390767aa866e322c762038c12116a15b280af1a Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/81206 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/ec/hp/kbc1126/acpi/ac.asl M src/ec/hp/kbc1126/acpi/ec.asl 2 files changed, 0 insertions(+), 10 deletions(-)
Approvals: Nico Huber: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/ec/hp/kbc1126/acpi/ac.asl b/src/ec/hp/kbc1126/acpi/ac.asl index 59681cf..9743045 100644 --- a/src/ec/hp/kbc1126/acpi/ac.asl +++ b/src/ec/hp/kbc1126/acpi/ac.asl @@ -47,11 +47,6 @@ Name (_HID, "ACPI0003") Name (_PCL, Package () { _SB })
- Method (_STA) - { - Return (0x0F) - } - Method (_PSR) { Local0 = GACS () diff --git a/src/ec/hp/kbc1126/acpi/ec.asl b/src/ec/hp/kbc1126/acpi/ec.asl index afe0a70..ef68cc4 100644 --- a/src/ec/hp/kbc1126/acpi/ec.asl +++ b/src/ec/hp/kbc1126/acpi/ec.asl @@ -12,11 +12,6 @@ IO (Decode16, 0x66, 0x66, 1, 1) })
- Method (_STA) - { - Return (0x0F) - } - OperationRegion (ECRM, EmbeddedControl, 0x00, 0xFF) Field (ECRM, ByteAcc, NoLock, Preserve) {