Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36892 )
Change subject: mb/hp/revolve_810_g1: Don't clear BUC and beyond ......................................................................
mb/hp/revolve_810_g1: Don't clear BUC and beyond
The BUC register is actually 16 bits wide and shouldn't be bluntly cleared.
Change-Id: I2ffd2d161005e839e730102b56af4f66efeb551e Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/hp/revolve_810_g1/early_init.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/36892/1
diff --git a/src/mainboard/hp/revolve_810_g1/early_init.c b/src/mainboard/hp/revolve_810_g1/early_init.c index b464ce3..1245201 100644 --- a/src/mainboard/hp/revolve_810_g1/early_init.c +++ b/src/mainboard/hp/revolve_810_g1/early_init.c @@ -25,11 +25,6 @@ #include <southbridge/intel/bd82x6x/pch.h> #include <ec/hp/kbc1126/ec.h>
-void mainboard_late_rcba_config(void) -{ - RCBA32(BUC) = 0x00000000; -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, { 1, 0, 0 },
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36892 )
Change subject: mb/hp/revolve_810_g1: Don't clear BUC and beyond ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36892 )
Change subject: mb/hp/revolve_810_g1: Don't clear BUC and beyond ......................................................................
Patch Set 1: Code-Review+2
Hello Patrick Rudolph, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36892
to look at the new patch set (#2).
Change subject: mb/hp/revolve_810_g1: Don't clear BUC and beyond ......................................................................
mb/hp/revolve_810_g1: Don't clear BUC and beyond
The BUC register is actually 8 bits wide and shouldn't be bluntly cleared.
Change-Id: I2ffd2d161005e839e730102b56af4f66efeb551e Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/hp/revolve_810_g1/early_init.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/36892/2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36892 )
Change subject: mb/hp/revolve_810_g1: Don't clear BUC and beyond ......................................................................
mb/hp/revolve_810_g1: Don't clear BUC and beyond
The BUC register is actually 8 bits wide and shouldn't be bluntly cleared.
Change-Id: I2ffd2d161005e839e730102b56af4f66efeb551e Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/36892 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/hp/revolve_810_g1/early_init.c 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/hp/revolve_810_g1/early_init.c b/src/mainboard/hp/revolve_810_g1/early_init.c index b464ce3..1245201 100644 --- a/src/mainboard/hp/revolve_810_g1/early_init.c +++ b/src/mainboard/hp/revolve_810_g1/early_init.c @@ -25,11 +25,6 @@ #include <southbridge/intel/bd82x6x/pch.h> #include <ec/hp/kbc1126/ec.h>
-void mainboard_late_rcba_config(void) -{ - RCBA32(BUC) = 0x00000000; -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, { 1, 0, 0 },
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)