Attention is currently required from: Sean Rhodes, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62990 )
Change subject: drivers/smmstore: Enable 4KiB blocks in SMMSTORE ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Sorry dude, the logic is lost on me. If we don't change any defaults, someone selects an option that breaks something because they haven't read up on it, it's trial and error anyway - they'd just unselect it...
No I disagree. Bad ports are like that. It's not because for some bad platforms the myriad of options allows for some broken combinations that this a good idea to introduce motr options like that. Ideally you want to have features exposed in menuconfig and sometimes alternative codepaths. What you don't want to expose are implementation details.
Have you tried the following using native coreboot tools to edit the layout?
No, as it would break the manifest.
What do you mean? Are there hardcoded assumptions when building the manifest about the memory mapping?
-
Arthur Heymans (Code Review)