Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43778 )
Change subject: sb/intel/lynxpoint: Add debug print ......................................................................
sb/intel/lynxpoint: Add debug print
Sometimes, `root_port_commit_config` may not get called, leaving the PCH PCIe root ports partially initialized. Windows 10 BSODs with a rather unhelpful message when this happens. To ease debugging, always print an easily-greppable message when the problematic function gets called.
Change-Id: Icf53c17a207755b1d8d3e9e895e06c95a4f47b6a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/lynxpoint/pcie.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43778/1
diff --git a/src/southbridge/intel/lynxpoint/pcie.c b/src/southbridge/intel/lynxpoint/pcie.c index d2950e7..9d4dc19 100644 --- a/src/southbridge/intel/lynxpoint/pcie.c +++ b/src/southbridge/intel/lynxpoint/pcie.c @@ -267,6 +267,8 @@ { int i;
+ printk(BIOS_DEBUG, "%s: Finishing PCIe initialization\n", __func__); + /* If the first root port is disabled the coalesce ports. */ if (!is_rp_enabled(1)) rpc.coalesce = 1;
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43778 )
Change subject: sb/intel/lynxpoint: Add debug print ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43778/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43778/1//COMMIT_MSG@11 PS1, Line 11: unhelpful message when this happens. To ease debugging, always print an It’d be great if you quoted the message here, so people with the same issue, can find the commit.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43778 )
Change subject: sb/intel/lynxpoint: Add debug print ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43778/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43778/1//COMMIT_MSG@11 PS1, Line 11: unhelpful message when this happens. To ease debugging, always print an
It’d be great if you quoted the message here, so people with the same issue, can find the commit.
This commit won't fix that problem, though. It merely eases troubleshooting.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43778 )
Change subject: sb/intel/lynxpoint: Add debug print ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43778/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/43778/1/src/southbridge/intel/lynxp... PS1, Line 270: %s: Nit, not sure how useful the function name is, one can also grep for the message. Also, other BIOS_DEBUG prints around don't use a prefix.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43778 )
Change subject: sb/intel/lynxpoint: Add debug print ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43778/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/43778/1/src/southbridge/intel/lynxp... PS1, Line 270: %s:
Nit, not sure how useful the function name is, one can also grep for the […]
It's just to make it long and stick out noticeably in logs.
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43778 )
Change subject: sb/intel/lynxpoint: Add debug print ......................................................................
Abandoned
Prefer CB:44155 which actually fixes the problem and adds a more helpful debug print.
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)