Attention is currently required from: Hung-Te Lin, Arthur Heymans, Paul Menzel.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56793 )
Change subject: soc/mediatek/mt8195: Enable PCIe support for mt8195
......................................................................
Patch Set 18:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56793/comment/bf34b487_3a302f0b
PS18, Line 7: for mt8195
Can be removed.
File src/soc/mediatek/mt8195/Kconfig:
https://review.coreboot.org/c/coreboot/+/56793/comment/9aad5a23_b5b4fbc5
PS8, Line 13: select PCIE_MEDIATEK
On the other hand, if there's no easy way to do that
CB:62360, which actually enables PCI, is done using coreboot device tree (at least from the patch chain that is the only mainboard CL). I'm not sure if we want to have a devicetree.cb per board.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56793
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I314572955f1021abe9f2f0f4635670135ed08fff
Gerrit-Change-Number: 56793
Gerrit-PatchSet: 18
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 07 Mar 2022 05:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-MessageType: comment