Attention is currently required from: Dinesh Gehlot, Eric Lai, Ivan Chen, Jamie Chen, Kapil Porwal, Matt DeVillier, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80769?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya/var/omniknight: remove Implement touchscreen power sequencing
......................................................................
Patch Set 7:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80769/comment/0b43e1a3_2e16493d :
PS7, Line 7: remove Implement
Remove
https://review.coreboot.org/c/coreboot/+/80769/comment/948d7ae9_1634707d :
PS7, Line 11: #comment36
Comment in what thread?
https://review.coreboot.org/c/coreboot/+/80769/comment/03213b4e_2eceea5a :
PS7, Line 11: pre
per
https://review.coreboot.org/c/coreboot/+/80769/comment/eb3eff38_a7b364bb :
PS7, Line 11: no
does not
https://review.coreboot.org/c/coreboot/+/80769/comment/10a45f0b_8010ce33 :
PS7, Line 12: it may have ghost touch
Sorry, I do not understand.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I66f4a7915f135927fbc0a16254dece202dfc23a2
Gerrit-Change-Number: 80769
Gerrit-PatchSet: 7
Gerrit-Owner: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Comment-Date: Mon, 04 Mar 2024 13:34:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment