Attention is currently required from: Alicja Michalska, Christian Walter, Eric Lai, Felix Held, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Shuo Liu, Tim Chu, yuchi.chen@intel.com.
Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85170?usp=email )
Change subject: soc/intel/xeon_sp/skx: Configure IOAPICs
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85170/comment/2e943eba_497e99e7?usp... :
PS7, Line 10: all IOAPICs to assign unique IDs to each. Every IOAPIC has 8 GSIs,
`'excat' may be misspelled - perhaps 'exact'?`
Please fix.
File src/soc/intel/xeon_sp/skx/ioapic.c:
https://review.coreboot.org/c/coreboot/+/85170/comment/af2b5c44_facdbfb3?usp... :
PS7, Line 42: /* Assign socket specific GSI_BASE */
: if (dn.socket == 0) {
: gsi_base = 24 + dn.stack * 8;
: } else {
: gsi_base = 72 + dn.stack * 8;
: }
Out of curiosity, is there any reason for the magic numbers 24 and 72? AIUI this wouldn't work properly for more than 2 sockets, how about:
```suggestion
/* Assign socket specific GSI_BASE */
const u32 gsi_base = 24 + dn.socket * 48 + dn.stack * 8;
```
Note that this seems to assume `dn.stack < 6` (which may be guaranteed by how many stacks a socket can have).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85170?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3bd69e6293b1994a4b3a49361fa7eb45cc0a3a5f
Gerrit-Change-Number: 85170
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alicja Michalska
ahplka19@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 04 Dec 2024 11:41:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes