[M] Change in coreboot[main]: soc/intel/xeon_sp/skx: Configure IOAPICs

[Angel Pons (Code Review)]

Attention is currently required from: Alicja Michalska, Christian Walter, Eric Lai, Felix Held, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Shuo Liu, Tim Chu, [e-mail].

Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85170?usp=email )

Change subject: soc/intel/xeon_sp/skx: Configure IOAPICs
......................................................................

Patch Set 7: Code-Review+1

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85170/comment/2e943eba_497e99e7?usp... :
PS7, Line 10: all IOAPICs to assign unique IDs to each. Every IOAPIC has 8 GSIs,
> `'excat' may be misspelled - perhaps 'exact'?`

Please fix.

File src/soc/intel/xeon_sp/skx/ioapic.c:

https://review.coreboot.org/c/coreboot/+/85170/comment/af2b5c44_facdbfb3?usp... :
PS7, Line 42: /* Assign socket specific GSI_BASE */
            : 	if (dn.socket == 0) {
            : 		gsi_base = 24 + dn.stack * 8;
            : 	} else {
            : 		gsi_base = 72 + dn.stack * 8;
            : 	}
Out of curiosity, is there any reason for the magic numbers 24 and 72? AIUI this wouldn't work properly for more than 2 sockets, how about:

```suggestion
    /* Assign socket specific GSI_BASE */
    const u32 gsi_base = 24 + dn.socket * 48 + dn.stack * 8;
```

Note that this seems to assume `dn.stack < 6` (which may be guaranteed by how many stacks a socket can have).