Ping-chung Chen has posted comments on this change. ( https://review.coreboot.org/27350 )
Change subject: mb/google/atlas: MIPI camera ASL files for Atlas ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/atlas/devicetree.cb:
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/... PS5, Line 43:
Please remove these comments
Done
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/... PS5, Line 44:
Ditto
Done
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl:
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/... PS5, Line 18: /* Define the port for CIO2 device where endpoint of port0 : is connected to CAM0 */
Please fix these comments as Atlas uses a single camera.
Done
-
Ping-chung Chen (Code Review)