Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37010 )
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
sb/intel/common/smihandler: Use a common IO TRAP handler
This adds the get_gnvs_smif callback to get smif from the sb dependent gnvs struct.
Change-Id: I85ff060012f68087edce6946b05181ee6b84a135 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/bd82x6x/smihandler.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/i82801gx/smihandler.c M src/southbridge/intel/i82801ix/smihandler.c M src/southbridge/intel/i82801jx/smihandler.c 6 files changed, 64 insertions(+), 196 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/37010/1
diff --git a/src/southbridge/intel/bd82x6x/smihandler.c b/src/southbridge/intel/bd82x6x/smihandler.c index ceac598..f292b6f 100644 --- a/src/southbridge/intel/bd82x6x/smihandler.c +++ b/src/southbridge/intel/bd82x6x/smihandler.c @@ -151,58 +151,9 @@ } }
-void southbridge_smi_monitor(void) +uint8_t get_gnvs_smif(void) { -#define IOTRAP(x) (trap_sts & (1 << x)) - u32 trap_sts, trap_cycle; - u32 data, mask = 0; - int i; - - trap_sts = RCBA32(0x1e00); // TRSR - Trap Status Register - RCBA32(0x1e00) = trap_sts; // Clear trap(s) in TRSR - - trap_cycle = RCBA32(0x1e10); - for (i=16; i<20; i++) { - if (trap_cycle & (1 << i)) - mask |= (0xff << ((i - 16) << 2)); - } - - - /* IOTRAP(3) SMI function call */ - if (IOTRAP(3)) { - if (gnvs && gnvs->smif) - io_trap_handler(gnvs->smif); // call function smif - return; - } - - /* IOTRAP(2) currently unused - * IOTRAP(1) currently unused */ - - /* IOTRAP(0) SMIC */ - if (IOTRAP(0)) { - if (!(trap_cycle & (1 << 24))) { // It's a write - printk(BIOS_DEBUG, "SMI1 command\n"); - data = RCBA32(0x1e18); - data &= mask; - // if (smi1) - // southbridge_smi_command(data); - // return; - } - // Fall through to debug - } - - printk(BIOS_DEBUG, " trapped io address = 0x%x\n", trap_cycle & 0xfffc); - for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); - printk(BIOS_DEBUG, " AHBE = %x\n", (trap_cycle >> 16) & 0xf); - printk(BIOS_DEBUG, " MASK = 0x%08x\n", mask); - printk(BIOS_DEBUG, " read/write: %s\n", (trap_cycle & (1 << 24)) ? "read" : "write"); - - if (!(trap_cycle & (1 << 24))) { - /* Write Cycle */ - data = RCBA32(0x1e18); - printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", data); - } -#undef IOTRAP + return gnvs->smif; }
void southbridge_smm_xhci_sleep(u8 slp_type) diff --git a/src/southbridge/intel/common/pmutil.h b/src/southbridge/intel/common/pmutil.h index cea5c82..6af8805 100644 --- a/src/southbridge/intel/common/pmutil.h +++ b/src/southbridge/intel/common/pmutil.h @@ -144,7 +144,7 @@ void southbridge_gate_memory_reset(void); void southbridge_update_gnvs(u8 apm_cnt, int *smm_done); void southbridge_finalize_all(void); -void southbridge_smi_monitor(void); +uint8_t get_gnvs_smif(void); em64t101_smm_state_save_area_t *smi_apmc_find_state_save(u8 cmd); void pch_log_state(void);
diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c index 7f376fd..46fe28a 100644 --- a/src/southbridge/intel/common/smihandler.c +++ b/src/southbridge/intel/common/smihandler.c @@ -30,6 +30,7 @@ #include <smmstore.h>
#include "pmutil.h" +#include "rcba.h"
static int smm_initialized = 0;
@@ -455,6 +456,60 @@ printk(BIOS_DEBUG, "Periodic SMI.\n"); }
+static void southbridge_smi_monitor(void) +{ +#define IOTRAP(x) (trap_sts & (1 << x)) + u32 trap_sts, trap_cycle; + u32 data, mask = 0; + int i; + + trap_sts = RCBA32(0x1e00); // TRSR - Trap Status Register + RCBA32(0x1e00) = trap_sts; // Clear trap(s) in TRSR + + trap_cycle = RCBA32(0x1e10); + for (i=16; i<20; i++) { + if (trap_cycle & (1 << i)) + mask |= (0xff << ((i - 16) << 2)); + } + + + /* IOTRAP(3) SMI function call */ + if (IOTRAP(3)) { + io_trap_handler(get_gnvs_smif()); + return; + } + + /* IOTRAP(2) currently unused + * IOTRAP(1) currently unused */ + + /* IOTRAP(0) SMIC */ + if (IOTRAP(0)) { + if (!(trap_cycle & (1 << 24))) { // It's a write + printk(BIOS_DEBUG, "SMI1 command\n"); + data = RCBA32(0x1e18); + data &= mask; + // if (smi1) + // southbridge_smi_command(data); + // return; + } + // Fall through to debug + } + + printk(BIOS_DEBUG, " trapped io address = 0x%x\n", trap_cycle & 0xfffc); + for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); + printk(BIOS_DEBUG, " AHBE = %x\n", (trap_cycle >> 16) & 0xf); + printk(BIOS_DEBUG, " MASK = 0x%08x\n", mask); + printk(BIOS_DEBUG, " read/write: %s\n", (trap_cycle & (1 << 24)) ? "read" : "write"); + + if (!(trap_cycle & (1 << 24))) { + /* Write Cycle */ + data = RCBA32(0x1e18); + printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", data); + } +#undef IOTRAP +} + + typedef void (*smi_handler_t)(void);
static smi_handler_t southbridge_smi[32] = { diff --git a/src/southbridge/intel/i82801gx/smihandler.c b/src/southbridge/intel/i82801gx/smihandler.c index 16ceb13..1aacbca 100644 --- a/src/southbridge/intel/i82801gx/smihandler.c +++ b/src/southbridge/intel/i82801gx/smihandler.c @@ -66,49 +66,9 @@ return 0; }
-void southbridge_smi_monitor(void) +uint8_t get_gnvs_smif(void) { -#define IOTRAP(x) (trap_sts & (1 << x)) - u32 trap_sts, trap_cycle; - u32 data, mask = 0; - int i; - - trap_sts = RCBA32(0x1e00); // TRSR - Trap Status Register - RCBA32(0x1e00) = trap_sts; // Clear trap(s) in TRSR - - trap_cycle = RCBA32(0x1e10); - for (i = 16; i < 20; i++) { - if (trap_cycle & (1 << i)) - mask |= (0xff << ((i - 16) << 2)); - } - - - /* IOTRAP(3) SMI function call */ - if (IOTRAP(3)) { - if (gnvs && gnvs->smif) - io_trap_handler(gnvs->smif); // call function smif - return; - } - - /* IOTRAP(2) currently unused - * IOTRAP(1) currently unused */ - - /* IOTRAP(0) SMIC: currently unused */ - - printk(BIOS_DEBUG, " trapped io address = 0x%x\n", trap_cycle & 0xfffc); - for (i = 0; i < 4; i++) - if (IOTRAP(i)) - printk(BIOS_DEBUG, " TRAP = %d\n", i); - printk(BIOS_DEBUG, " AHBE = %x\n", (trap_cycle >> 16) & 0xf); - printk(BIOS_DEBUG, " MASK = 0x%08x\n", mask); - printk(BIOS_DEBUG, " read/write: %s\n", (trap_cycle & (1 << 24)) ? "read" : "write"); - - if (!(trap_cycle & (1 << 24))) { - /* Write Cycle */ - data = RCBA32(0x1e18); - printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", data); - } -#undef IOTRAP + return gnvs->smif; }
void southbridge_finalize_all(void) diff --git a/src/southbridge/intel/i82801ix/smihandler.c b/src/southbridge/intel/i82801ix/smihandler.c index 8090a09..96a9e2a 100644 --- a/src/southbridge/intel/i82801ix/smihandler.c +++ b/src/southbridge/intel/i82801ix/smihandler.c @@ -57,58 +57,9 @@ *smm_done = 1; }
-void southbridge_smi_monitor(void) +uint8_t get_gnvs_smif(void) { -#define IOTRAP(x) (trap_sts & (1 << x)) - u32 trap_sts, trap_cycle; - u32 data, mask = 0; - int i; - - trap_sts = RCBA32(0x1e00); // TRSR - Trap Status Register - RCBA32(0x1e00) = trap_sts; // Clear trap(s) in TRSR - - trap_cycle = RCBA32(0x1e10); - for (i=16; i<20; i++) { - if (trap_cycle & (1 << i)) - mask |= (0xff << ((i - 16) << 3)); - } - - - /* IOTRAP(3) SMI function call */ - if (IOTRAP(3)) { - if (gnvs && gnvs->smif) - io_trap_handler(gnvs->smif); // call function smif - return; - } - - /* IOTRAP(2) currently unused - * IOTRAP(1) currently unused */ - - /* IOTRAP(0) SMIC */ - if (IOTRAP(0)) { - if (!(trap_cycle & (1 << 24))) { // It's a write - printk(BIOS_DEBUG, "SMI1 command\n"); - data = RCBA32(0x1e18); - data &= mask; - // if (smi1) - // southbridge_smi_command(data); - // return; - } - // Fall through to debug - } - - printk(BIOS_DEBUG, " trapped io address = 0x%x\n", trap_cycle & 0xfffc); - for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); - printk(BIOS_DEBUG, " AHBE = %x\n", (trap_cycle >> 16) & 0xf); - printk(BIOS_DEBUG, " MASK = 0x%08x\n", mask); - printk(BIOS_DEBUG, " read/write: %s\n", (trap_cycle & (1 << 24)) ? "read" : "write"); - - if (!(trap_cycle & (1 << 24))) { - /* Write Cycle */ - data = RCBA32(0x1e18); - printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", data); - } -#undef IOTRAP + return gnvs->smif; }
void southbridge_finalize_all(void) diff --git a/src/southbridge/intel/i82801jx/smihandler.c b/src/southbridge/intel/i82801jx/smihandler.c index 667a853..6ed5edd 100644 --- a/src/southbridge/intel/i82801jx/smihandler.c +++ b/src/southbridge/intel/i82801jx/smihandler.c @@ -64,58 +64,9 @@ *smm_done = 1; }
-void southbridge_smi_monitor(void) +uint8_t get_gnvs_smif(void) { -#define IOTRAP(x) (trap_sts & (1 << x)) - u32 trap_sts, trap_cycle; - u32 data, mask = 0; - int i; - - trap_sts = RCBA32(0x1e00); // TRSR - Trap Status Register - RCBA32(0x1e00) = trap_sts; // Clear trap(s) in TRSR - - trap_cycle = RCBA32(0x1e10); - for (i=16; i<20; i++) { - if (trap_cycle & (1 << i)) - mask |= (0xff << ((i - 16) << 3)); - } - - - /* IOTRAP(3) SMI function call */ - if (IOTRAP(3)) { - if (gnvs && gnvs->smif) - io_trap_handler(gnvs->smif); // call function smif - return; - } - - /* IOTRAP(2) currently unused - * IOTRAP(1) currently unused */ - - /* IOTRAP(0) SMIC */ - if (IOTRAP(0)) { - if (!(trap_cycle & (1 << 24))) { // It's a write - printk(BIOS_DEBUG, "SMI1 command\n"); - data = RCBA32(0x1e18); - data &= mask; - // if (smi1) - // southbridge_smi_command(data); - // return; - } - // Fall through to debug - } - - printk(BIOS_DEBUG, " trapped io address = 0x%x\n", trap_cycle & 0xfffc); - for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); - printk(BIOS_DEBUG, " AHBE = %x\n", (trap_cycle >> 16) & 0xf); - printk(BIOS_DEBUG, " MASK = 0x%08x\n", mask); - printk(BIOS_DEBUG, " read/write: %s\n", (trap_cycle & (1 << 24)) ? "read" : "write"); - - if (!(trap_cycle & (1 << 24))) { - /* Write Cycle */ - data = RCBA32(0x1e18); - printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", data); - } -#undef IOTRAP + return gnvs->smif; }
void southbridge_finalize_all(void)
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37010 )
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37010/1/src/southbridge/intel/commo... File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/37010/1/src/southbridge/intel/commo... PS1, Line 470: for (i=16; i<20; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/1/src/southbridge/intel/commo... PS1, Line 470: for (i=16; i<20; i++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/1/src/southbridge/intel/commo... PS1, Line 499: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/1/src/southbridge/intel/commo... PS1, Line 499: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); trailing statements should be on next line
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37010
to look at the new patch set (#2).
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
sb/intel/common/smihandler: Use a common IO TRAP handler
This adds the get_gnvs_smif callback to get smif from the sb dependent gnvs struct.
Change-Id: I85ff060012f68087edce6946b05181ee6b84a135 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/bd82x6x/smihandler.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/i82801gx/smihandler.c M src/southbridge/intel/i82801ix/smihandler.c M src/southbridge/intel/i82801jx/smihandler.c M src/southbridge/intel/ibexpeak/smihandler.c 7 files changed, 66 insertions(+), 247 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/37010/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37010 )
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37010/2/src/southbridge/intel/commo... File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/37010/2/src/southbridge/intel/commo... PS2, Line 470: for (i=16; i<20; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/2/src/southbridge/intel/commo... PS2, Line 470: for (i=16; i<20; i++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/2/src/southbridge/intel/commo... PS2, Line 499: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/2/src/southbridge/intel/commo... PS2, Line 499: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); trailing statements should be on next line
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37010 )
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37010/3/src/southbridge/intel/commo... File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/37010/3/src/southbridge/intel/commo... PS3, Line 470: for (i=16; i<20; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/3/src/southbridge/intel/commo... PS3, Line 470: for (i=16; i<20; i++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/3/src/southbridge/intel/commo... PS3, Line 499: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/3/src/southbridge/intel/commo... PS3, Line 499: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); trailing statements should be on next line
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37010
to look at the new patch set (#4).
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
sb/intel/common/smihandler: Use a common IO TRAP handler
This adds the get_gnvs_smif callback to get smif from the sb dependent gnvs struct.
Change-Id: I85ff060012f68087edce6946b05181ee6b84a135 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/bd82x6x/smihandler.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/i82801gx/smihandler.c M src/southbridge/intel/i82801ix/smihandler.c M src/southbridge/intel/i82801jx/smihandler.c M src/southbridge/intel/ibexpeak/smihandler.c 7 files changed, 66 insertions(+), 247 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/37010/4
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37010 )
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37010/4/src/southbridge/intel/commo... File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/37010/4/src/southbridge/intel/commo... PS4, Line 470: for (i=16; i<20; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/4/src/southbridge/intel/commo... PS4, Line 470: for (i=16; i<20; i++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/4/src/southbridge/intel/commo... PS4, Line 499: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/4/src/southbridge/intel/commo... PS4, Line 499: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); trailing statements should be on next line
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37010
to look at the new patch set (#5).
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
sb/intel/common/smihandler: Use a common IO TRAP handler
This adds the get_gnvs_smif callback to get smif from the sb dependent gnvs struct.
Change-Id: I85ff060012f68087edce6946b05181ee6b84a135 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/bd82x6x/smihandler.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/i82801gx/smihandler.c M src/southbridge/intel/i82801ix/smihandler.c M src/southbridge/intel/i82801jx/smihandler.c M src/southbridge/intel/ibexpeak/smihandler.c 7 files changed, 68 insertions(+), 247 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/37010/5
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37010 )
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37010/5/src/southbridge/intel/commo... File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/37010/5/src/southbridge/intel/commo... PS5, Line 472: mask |= (0xff << ((i - 16) << 2)); (i - 16) * 8?
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37010
to look at the new patch set (#6).
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
sb/intel/common/smihandler: Use a common IO TRAP handler
This adds the get_gnvs_smif callback to get smif from the sb dependent gnvs struct.
This probably fixes a bug on bd82x6x, i82801gx and ibexpeak where a wrong mask was calculated to get TWDR (RCBA 0x1e18)).
Change-Id: I85ff060012f68087edce6946b05181ee6b84a135 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/bd82x6x/smihandler.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/i82801gx/smihandler.c M src/southbridge/intel/i82801ix/smihandler.c M src/southbridge/intel/i82801jx/smihandler.c M src/southbridge/intel/ibexpeak/smihandler.c 7 files changed, 66 insertions(+), 247 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/37010/6
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37010 )
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37010/6/src/southbridge/intel/commo... File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/37010/6/src/southbridge/intel/commo... PS6, Line 469: for (i=16; i<20; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/6/src/southbridge/intel/commo... PS6, Line 469: for (i=16; i<20; i++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/6/src/southbridge/intel/commo... PS6, Line 498: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/6/src/southbridge/intel/commo... PS6, Line 498: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); trailing statements should be on next line
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37010 )
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
Abandoned
superseded in common_smm_save_state
-
Arthur Heymans (Code Review) -
build bot (Jenkins) (Code Review)
-
Patrick Rudolph (Code Review)