Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu, Yidi Lin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69089 )
Change subject: soc/mediatek/mt8188: Disable input-gating for big-core SRAM
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69089/comment/f1c38ff6_75d979cb
PS1, Line 9: This patch fixes AP hanging issue caused by CPU input gating. The
: feature should be disabled by default, so we disable it.
- CPU input gating (IG), please refer to https://ieeexplore.ieee.org/stamp/stamp. […]
Looks like this change is setting some chicken bits to disable a feature that doesn't work as intended: https://en.wiktionary.org/wiki/chicken_bit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd68fe9362587955cdb8598c4cc5c2d0eefe53ca
Gerrit-Change-Number: 69089
Gerrit-PatchSet: 10
Gerrit-Owner: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Wed, 02 Nov 2022 09:55:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-MessageType: comment