Nico Huber has posted comments on this change. ( https://review.coreboot.org/27062 )
Change subject: gma: Turn constants depending on Config.CPU* into functions ......................................................................
Patch Set 1: Verified+1
(1 comment)
https://review.coreboot.org/#/c/27062/1/common/ironlake/hw-gfx-gma-connector... File common/ironlake/hw-gfx-gma-connectors-fdi.adb:
https://review.coreboot.org/#/c/27062/1/common/ironlake/hw-gfx-gma-connector... PS1, Line 51: DP_Info. maybe add `use HW.GFX.GMA.DP_Info.Training_Pattern;`?