Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49127 )
Change subject: ACPI: Remove ACPI_NO_SMI_GNVS ......................................................................
ACPI: Remove ACPI_NO_SMI_GNVS
This was used as a guard to not raise SMI with APM_CNT_GNVS_UPDATE. The handler has been removed now completely.
Change-Id: I7726367fd16630aa4b4b25b24b05f740645066db Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/acpi/Kconfig M src/cpu/amd/agesa/Kconfig M src/cpu/amd/pi/Kconfig M src/soc/amd/picasso/Kconfig M src/soc/amd/stoneyridge/Kconfig M src/soc/intel/xeon_sp/Kconfig 6 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/49127/1
diff --git a/src/acpi/Kconfig b/src/acpi/Kconfig index 07008db..11ef12a3 100644 --- a/src/acpi/Kconfig +++ b/src/acpi/Kconfig @@ -24,9 +24,6 @@ Provide common definitions for Intel hardware PM1_CNT register sleep values.
-config ACPI_NO_SMI_GNVS - bool - config ACPI_NO_PCAT_8259 bool help diff --git a/src/cpu/amd/agesa/Kconfig b/src/cpu/amd/agesa/Kconfig index 1ccfa5d..b144fc1 100644 --- a/src/cpu/amd/agesa/Kconfig +++ b/src/cpu/amd/agesa/Kconfig @@ -14,7 +14,6 @@ select SPI_FLASH if HAVE_ACPI_RESUME select SMM_ASEG select SSE2 - select ACPI_NO_SMI_GNVS
if CPU_AMD_AGESA
diff --git a/src/cpu/amd/pi/Kconfig b/src/cpu/amd/pi/Kconfig index dff896f..d3a94a8c 100644 --- a/src/cpu/amd/pi/Kconfig +++ b/src/cpu/amd/pi/Kconfig @@ -13,7 +13,6 @@ select SPI_FLASH if HAVE_ACPI_RESUME select SMM_ASEG select SSE2 - select ACPI_NO_SMI_GNVS
if CPU_AMD_PI
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index e9930e9..4d31267 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -57,7 +57,6 @@ select UDK_2017_BINDING select HAVE_CF9_RESET select SUPPORT_CPU_UCODE_IN_CBFS - select ACPI_NO_SMI_GNVS
config FSP_M_FILE string "FSP-M (memory init) binary path and filename" diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index b95dbf4..7d2ad21 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -10,7 +10,6 @@ config CPU_SPECIFIC_OPTIONS def_bool y select ACPI_AMD_HARDWARE_SLEEP_VALUES - select ACPI_NO_SMI_GNVS select ARCH_ALL_STAGES_X86_32 select BOOT_DEVICE_SUPPORTS_WRITES if BOOT_DEVICE_SPI_FLASH select COLLECT_TIMESTAMPS_NO_TSC diff --git a/src/soc/intel/xeon_sp/Kconfig b/src/soc/intel/xeon_sp/Kconfig index 3b95c70..a8cecc5 100644 --- a/src/soc/intel/xeon_sp/Kconfig +++ b/src/soc/intel/xeon_sp/Kconfig @@ -36,7 +36,6 @@ select POSTCAR_STAGE select IOAPIC select PARALLEL_MP - select ACPI_NO_SMI_GNVS select INTEL_DESCRIPTOR_MODE_CAPABLE select SOC_INTEL_COMMON_BLOCK select SOC_INTEL_COMMON_BLOCK_CPU
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49127 )
Change subject: ACPI: Remove ACPI_NO_SMI_GNVS ......................................................................
Patch Set 1: Code-Review+2
Attention is currently required from: Kyösti Mälkki. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49127 )
Change subject: ACPI: Remove ACPI_NO_SMI_GNVS ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49127 )
Change subject: ACPI: Remove ACPI_NO_SMI_GNVS ......................................................................
ACPI: Remove ACPI_NO_SMI_GNVS
This was used as a guard to not raise SMI with APM_CNT_GNVS_UPDATE. The handler has been removed now completely.
Change-Id: I7726367fd16630aa4b4b25b24b05f740645066db Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49127 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de --- M src/acpi/Kconfig M src/cpu/amd/agesa/Kconfig M src/cpu/amd/pi/Kconfig M src/soc/amd/picasso/Kconfig M src/soc/amd/stoneyridge/Kconfig M src/soc/intel/xeon_sp/Kconfig 6 files changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/acpi/Kconfig b/src/acpi/Kconfig index 07008db..11ef12a3 100644 --- a/src/acpi/Kconfig +++ b/src/acpi/Kconfig @@ -24,9 +24,6 @@ Provide common definitions for Intel hardware PM1_CNT register sleep values.
-config ACPI_NO_SMI_GNVS - bool - config ACPI_NO_PCAT_8259 bool help diff --git a/src/cpu/amd/agesa/Kconfig b/src/cpu/amd/agesa/Kconfig index 1ccfa5d..b144fc1 100644 --- a/src/cpu/amd/agesa/Kconfig +++ b/src/cpu/amd/agesa/Kconfig @@ -14,7 +14,6 @@ select SPI_FLASH if HAVE_ACPI_RESUME select SMM_ASEG select SSE2 - select ACPI_NO_SMI_GNVS
if CPU_AMD_AGESA
diff --git a/src/cpu/amd/pi/Kconfig b/src/cpu/amd/pi/Kconfig index dff896f..d3a94a8c 100644 --- a/src/cpu/amd/pi/Kconfig +++ b/src/cpu/amd/pi/Kconfig @@ -13,7 +13,6 @@ select SPI_FLASH if HAVE_ACPI_RESUME select SMM_ASEG select SSE2 - select ACPI_NO_SMI_GNVS
if CPU_AMD_PI
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index e9930e9..4d31267 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -57,7 +57,6 @@ select UDK_2017_BINDING select HAVE_CF9_RESET select SUPPORT_CPU_UCODE_IN_CBFS - select ACPI_NO_SMI_GNVS
config FSP_M_FILE string "FSP-M (memory init) binary path and filename" diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index b95dbf4..7d2ad21 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -10,7 +10,6 @@ config CPU_SPECIFIC_OPTIONS def_bool y select ACPI_AMD_HARDWARE_SLEEP_VALUES - select ACPI_NO_SMI_GNVS select ARCH_ALL_STAGES_X86_32 select BOOT_DEVICE_SUPPORTS_WRITES if BOOT_DEVICE_SPI_FLASH select COLLECT_TIMESTAMPS_NO_TSC diff --git a/src/soc/intel/xeon_sp/Kconfig b/src/soc/intel/xeon_sp/Kconfig index 3b95c70..a8cecc5 100644 --- a/src/soc/intel/xeon_sp/Kconfig +++ b/src/soc/intel/xeon_sp/Kconfig @@ -36,7 +36,6 @@ select POSTCAR_STAGE select IOAPIC select PARALLEL_MP - select ACPI_NO_SMI_GNVS select INTEL_DESCRIPTOR_MODE_CAPABLE select SOC_INTEL_COMMON_BLOCK select SOC_INTEL_COMMON_BLOCK_CPU
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)