Attention is currently required from: Sugnan Prabhu S, Paul Menzel, Kane Chen.
Matt Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58951 )
Change subject: drivers/wifi/generic : fix package_size to align with WLAN driver
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58951/comment/015ef240_351bd944
PS4, Line 7: drivers/wifi/generic :
Please remove the space before the colon.
OK, will do.
https://review.coreboot.org/c/coreboot/+/58951/comment/2b4bee15_ae871d2c
PS4, Line 11: the WLAN driver check
What WLAN driver is that exactly?
This Intel WiFi driver, where is in kernel drivers/net/wireless/intel/iwlwifi/fw/acpi.c.
The variable sar->dsar_set_count is always 1 in CB, where WLAN driver expects 3[1].
[1]
#define ACPI_SAR_PROFILE_NUM 4
#define ACPI_EWRD_WIFI_DATA_SIZE_REV2 ((ACPI_SAR_PROFILE_NUM - 1) * \
ACPI_SAR_NUM_CHAINS_REV2 * \
ACPI_SAR_NUM_SUB_BANDS_REV2 + 3)
Then (ACPI_SAR_PROFILE_NUM - 1) is 3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18e7d5f658bbf42b7eeed3da330508f14b86c0f8
Gerrit-Change-Number: 58951
Gerrit-PatchSet: 4
Gerrit-Owner: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Janiex Tu
janiex.tu@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Fri, 05 Nov 2021 09:34:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment