Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39502 )
Change subject: mb/google/deltaur: add deltaur mainboard initial support ......................................................................
Patch Set 8:
(11 comments)
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 29:
/* Low power idle table */ […]
do you want to push this separately later? I didn't see it for tigerlake
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 40:
#include <vendorcode/google/chromeos/acpi/vpd. […]
Done
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 49:
Should we hold off on DPTF for now?
do you have some concern? I think taking out this file means, we will need to remove some Kconfig flags such as EC_GOOGLE_WILCO
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: ##
SPDX format please
Done
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/gpio.c:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /*
/* […]
Done
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /*
/* […]
Done
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /*
/* […]
Done
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: ##
SPDX
Done
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/gpio.c:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /*
/* […]
Done
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /*
/* […]
Done
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /*
/* […]
Done
-
Bora Guvendik (Code Review)