Attention is currently required from: Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48617 )
Change subject: soc/intel/dnv_ns: add gpio support to ramstage
......................................................................
Patch Set 26:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48617/comment/0e384f84_71bf6b36
PS26, Line 8:
It would be great to explain what this change is useful for. AFAIUI, it's needed for the follow-up? If so, why not squash this with CB:48618 then?
File src/soc/intel/denverton_ns/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48617/comment/f6e390d5_721c01e4
PS26, Line 55: ramstage-y += gpio_dnv.c
gpio_dnv.c is only used by mb/intel/harcuvar and CB:48618 shouldn't need it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48617
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibee49d107f9d751407aba909694680341a28343a
Gerrit-Change-Number: 48617
Gerrit-PatchSet: 26
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 06 Apr 2021 08:43:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment