Change in coreboot[master]: [Try] mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37749 )
Change subject: [Try] mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK ......................................................................
[Try] mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK
Untested.
Change-Id: I1584763e0029d4ea5966738c208c5589c53574d0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/union_station/Kconfig M src/mainboard/amd/union_station/Makefile.inc R src/mainboard/amd/union_station/bootblock.c 3 files changed, 4 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/37749/1
diff --git a/src/mainboard/amd/union_station/Kconfig b/src/mainboard/amd/union_station/Kconfig index f03fb08..72881b8 100644 --- a/src/mainboard/amd/union_station/Kconfig +++ b/src/mainboard/amd/union_station/Kconfig @@ -17,7 +17,6 @@
config BOARD_SPECIFIC_OPTIONS def_bool y - select ROMCC_BOOTBLOCK select CPU_AMD_AGESA_FAMILY14 select NORTHBRIDGE_AMD_AGESA_FAMILY14 select SOUTHBRIDGE_AMD_CIMX_SB800 diff --git a/src/mainboard/amd/union_station/Makefile.inc b/src/mainboard/amd/union_station/Makefile.inc index 440744c..ffea060 100644 --- a/src/mainboard/amd/union_station/Makefile.inc +++ b/src/mainboard/amd/union_station/Makefile.inc @@ -13,6 +13,8 @@ # GNU General Public License for more details. #
+bootblock-y += bootblock.c + romstage-y += buildOpts.c romstage-y += BiosCallOuts.c romstage-y += OemCustomize.c diff --git a/src/mainboard/amd/union_station/romstage.c b/src/mainboard/amd/union_station/bootblock.c similarity index 80% rename from src/mainboard/amd/union_station/romstage.c rename to src/mainboard/amd/union_station/bootblock.c index af64ad8..f0361d6 100644 --- a/src/mainboard/amd/union_station/romstage.c +++ b/src/mainboard/amd/union_station/bootblock.c @@ -13,10 +13,8 @@ * GNU General Public License for more details. */
-#include <northbridge/amd/agesa/state_machine.h> -#include <sb_cimx.h> +#include <bootblock_common.h>
-void board_BeforeAgesa(struct sysinfo *cb) +void bootblock_mainboard_early_init(void) { - sb_Poweron_Init(); }
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37749
to look at the new patch set (#2).
Change subject: mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: I1584763e0029d4ea5966738c208c5589c53574d0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/union_station/Kconfig M src/mainboard/amd/union_station/Kconfig.name M src/mainboard/amd/union_station/Makefile.inc R src/mainboard/amd/union_station/bootblock.c 4 files changed, 6 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/37749/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37749
to look at the new patch set (#3).
Change subject: mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware. To test, please fix the mainbord's Kconfig and Kconfig.name
Change-Id: I1584763e0029d4ea5966738c208c5589c53574d0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/union_station/Makefile.inc R src/mainboard/amd/union_station/bootblock.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/37749/3
Mike Banon has uploaded a new patch set (#4) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/37749 )
Change subject: mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: I1584763e0029d4ea5966738c208c5589c53574d0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/union_station/Kconfig M src/mainboard/amd/union_station/Kconfig.name M src/mainboard/amd/union_station/Makefile.inc R src/mainboard/amd/union_station/bootblock.c 4 files changed, 6 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/37749/4
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37749
to look at the new patch set (#9).
Change subject: [TESTME]mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK ......................................................................
[TESTME]mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: I1584763e0029d4ea5966738c208c5589c53574d0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/union_station/Kconfig M src/mainboard/amd/union_station/Kconfig.name M src/mainboard/amd/union_station/Makefile.inc R src/mainboard/amd/union_station/bootblock.c 4 files changed, 6 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/37749/9
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37749 )
Change subject: [TESTME]mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK ......................................................................
Abandoned
not tested
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/37749 )
Change subject: [TESTME]mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK ......................................................................
Restored
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37749 )
Change subject: [TESTME]mb/amd/union_station: Switch away from ROMCC_BOOTBLOCK ......................................................................
Abandoned
no one will test ... so drop unmaintained board
-
HAOUAS Elyes (Code Review) -
Mike Banon (Code Review)