Change in coreboot[master]: soc/intel/basecode: Add support for updating ucode loaded via FIT
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27369 )
Change subject: soc/intel/basecode: Add support for updating ucode loaded via FIT ......................................................................
Patch Set 20:
(3 comments)
https://review.coreboot.org/#/c/27369/20/src/soc/intel/common/basecode/fw_up... File src/soc/intel/common/basecode/fw_update/ucode_update.c:
https://review.coreboot.org/#/c/27369/20/src/soc/intel/common/basecode/fw_up... PS20, Line 157: printk(BIOS_INFO, "UCODE: Current ucode version: 0x%x\n", current_ucode); line over 80 characters
https://review.coreboot.org/#/c/27369/20/src/soc/intel/common/basecode/fw_up... PS20, Line 197: } else { else is not generally useful after a break or return
https://review.coreboot.org/#/c/27369/20/src/soc/intel/common/basecode/fw_up... PS20, Line 198: /* Update successfull */ 'successfull' may be misspelled - perhaps 'successful'?
-
build bot (Jenkins) (Code Review)