Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44251 )
Change subject: mb/{nb x4x}: Remove unused/deprecated cmos bits ......................................................................
mb/{nb x4x}: Remove unused/deprecated cmos bits
Receiver enable results are now saved in flash.
Change-Id: Ib1a985147b081860c58d1649c4e50301b8144b0c Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/asrock/g41c-gs/cmos.layout M src/mainboard/asus/p5qc/cmos.layout M src/mainboard/asus/p5qpl-am/cmos.layout M src/mainboard/foxconn/g41s-k/cmos.layout M src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout M src/mainboard/intel/dg41wv/cmos.layout M src/mainboard/intel/dg43gt/cmos.layout M src/mainboard/lenovo/thinkcentre_a58/cmos.layout 8 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/44251/1
diff --git a/src/mainboard/asrock/g41c-gs/cmos.layout b/src/mainboard/asrock/g41c-gs/cmos.layout index f90467cd..c4f1b08 100644 --- a/src/mainboard/asrock/g41c-gs/cmos.layout +++ b/src/mainboard/asrock/g41c-gs/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/asus/p5qc/cmos.layout b/src/mainboard/asus/p5qc/cmos.layout index 79f7347..3e8d5f0a 100644 --- a/src/mainboard/asus/p5qc/cmos.layout +++ b/src/mainboard/asus/p5qc/cmos.layout @@ -50,7 +50,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/asus/p5qpl-am/cmos.layout b/src/mainboard/asus/p5qpl-am/cmos.layout index 4905f1d..b1f6e77 100644 --- a/src/mainboard/asus/p5qpl-am/cmos.layout +++ b/src/mainboard/asus/p5qpl-am/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/foxconn/g41s-k/cmos.layout b/src/mainboard/foxconn/g41s-k/cmos.layout index f90467cd..c4f1b08 100644 --- a/src/mainboard/foxconn/g41s-k/cmos.layout +++ b/src/mainboard/foxconn/g41s-k/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout b/src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout index 79094e6..46940bd 100644 --- a/src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout +++ b/src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout @@ -53,7 +53,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/intel/dg41wv/cmos.layout b/src/mainboard/intel/dg41wv/cmos.layout index 4905f1d..b1f6e77 100644 --- a/src/mainboard/intel/dg41wv/cmos.layout +++ b/src/mainboard/intel/dg41wv/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/intel/dg43gt/cmos.layout b/src/mainboard/intel/dg43gt/cmos.layout index 79bb1b8..2174ecd 100644 --- a/src/mainboard/intel/dg43gt/cmos.layout +++ b/src/mainboard/intel/dg43gt/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/lenovo/thinkcentre_a58/cmos.layout b/src/mainboard/lenovo/thinkcentre_a58/cmos.layout index 4905f1d..b1f6e77 100644 --- a/src/mainboard/lenovo/thinkcentre_a58/cmos.layout +++ b/src/mainboard/lenovo/thinkcentre_a58/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44251 )
Change subject: mb/{nb x4x}: Remove unused/deprecated cmos bits ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44251/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44251/1//COMMIT_MSG@7 PS1, Line 7: mb/{nb x4x}: nit: x4x boards
Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44251
to look at the new patch set (#2).
Change subject: x4x boards: Remove unused/deprecated cmos bits ......................................................................
x4x boards: Remove unused/deprecated cmos bits
Receiver enable results are now saved in flash.
Change-Id: Ib1a985147b081860c58d1649c4e50301b8144b0c Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/asrock/g41c-gs/cmos.layout M src/mainboard/asus/p5qc/cmos.layout M src/mainboard/asus/p5qpl-am/cmos.layout M src/mainboard/foxconn/g41s-k/cmos.layout M src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout M src/mainboard/intel/dg41wv/cmos.layout M src/mainboard/intel/dg43gt/cmos.layout M src/mainboard/lenovo/thinkcentre_a58/cmos.layout 8 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/44251/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44251 )
Change subject: x4x boards: Remove unused/deprecated cmos bits ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44251/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44251/1//COMMIT_MSG@7 PS1, Line 7: mb/{nb x4x}:
nit: x4x boards
Done
Patrick Georgi has uploaded a new patch set (#3) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/44251 )
Change subject: x4x boards: Remove unused/deprecated cmos bits ......................................................................
x4x boards: Remove unused/deprecated cmos bits
Receiver enable results are now saved in flash.
Change-Id: Ib1a985147b081860c58d1649c4e50301b8144b0c Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/asrock/g41c-gs/cmos.layout M src/mainboard/asus/p5qc/cmos.layout M src/mainboard/asus/p5qpl-am/cmos.layout M src/mainboard/foxconn/g41s-k/cmos.layout M src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout M src/mainboard/intel/dg41wv/cmos.layout M src/mainboard/intel/dg43gt/cmos.layout M src/mainboard/lenovo/thinkcentre_a58/cmos.layout 8 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/44251/3
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44251 )
Change subject: x4x boards: Remove unused/deprecated cmos bits ......................................................................
x4x boards: Remove unused/deprecated cmos bits
Receiver enable results are now saved in flash.
Change-Id: Ib1a985147b081860c58d1649c4e50301b8144b0c Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/44251 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/g41c-gs/cmos.layout M src/mainboard/asus/p5qc/cmos.layout M src/mainboard/asus/p5qpl-am/cmos.layout M src/mainboard/foxconn/g41s-k/cmos.layout M src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout M src/mainboard/intel/dg41wv/cmos.layout M src/mainboard/intel/dg43gt/cmos.layout M src/mainboard/lenovo/thinkcentre_a58/cmos.layout 8 files changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/asrock/g41c-gs/cmos.layout b/src/mainboard/asrock/g41c-gs/cmos.layout index f90467c..c4f1b08 100644 --- a/src/mainboard/asrock/g41c-gs/cmos.layout +++ b/src/mainboard/asrock/g41c-gs/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/asus/p5qc/cmos.layout b/src/mainboard/asus/p5qc/cmos.layout index 79f7347..3e8d5f0a 100644 --- a/src/mainboard/asus/p5qc/cmos.layout +++ b/src/mainboard/asus/p5qc/cmos.layout @@ -50,7 +50,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/asus/p5qpl-am/cmos.layout b/src/mainboard/asus/p5qpl-am/cmos.layout index 4905f1d..b1f6e77 100644 --- a/src/mainboard/asus/p5qpl-am/cmos.layout +++ b/src/mainboard/asus/p5qpl-am/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/foxconn/g41s-k/cmos.layout b/src/mainboard/foxconn/g41s-k/cmos.layout index f90467c..c4f1b08 100644 --- a/src/mainboard/foxconn/g41s-k/cmos.layout +++ b/src/mainboard/foxconn/g41s-k/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout b/src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout index 79094e6..46940bd 100644 --- a/src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout +++ b/src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout @@ -53,7 +53,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/intel/dg41wv/cmos.layout b/src/mainboard/intel/dg41wv/cmos.layout index 4905f1d..b1f6e77 100644 --- a/src/mainboard/intel/dg41wv/cmos.layout +++ b/src/mainboard/intel/dg41wv/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/intel/dg43gt/cmos.layout b/src/mainboard/intel/dg43gt/cmos.layout index 79bb1b8..2174ecd 100644 --- a/src/mainboard/intel/dg43gt/cmos.layout +++ b/src/mainboard/intel/dg43gt/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations diff --git a/src/mainboard/lenovo/thinkcentre_a58/cmos.layout b/src/mainboard/lenovo/thinkcentre_a58/cmos.layout index 4905f1d..b1f6e77 100644 --- a/src/mainboard/lenovo/thinkcentre_a58/cmos.layout +++ b/src/mainboard/lenovo/thinkcentre_a58/cmos.layout @@ -52,7 +52,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-1024 144 r 0 recv_enable_results # -----------------------------------------------------------------
enumerations
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Georgi (Code Review)