Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41728 )
Change subject: drivers/intel/fsp2_0: Add FSP 2.2 specific support ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/in... File src/drivers/intel/fsp2_0/include/fsp/util.h:
https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/in... PS3, Line 31: number_of_phase nit; no_of_phases? or number_of_phases?
https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/si... PS3, Line 27: >= FSP specification : * 2.2 nit: FSP specification >= 2.2
https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/si... PS3, Line 41: fsp_handle_reset(status); nit: Handling reset based on FSP status is an error scenario?
https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/si... PS3, Line 140: post_code(POST_FSP_MULTI_PHASE_SI_INIT_ENTRY); nit: Should this be out of time measurement block?
-
Sridhar Siricilla (Code Review)