Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35794 )
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/...
PS2, Line 16: #define DPTF_CPU_PASSIVE 0
Just curious, why do we set DPTF_CPU_PASSIVE, DPTF_TSR1_PASSIVE, and DPTF_TSR2_PASSIVE 0? It seems l […]
Done
https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/...
PS2, Line 93: /* CPU Throttle Effect on CPU */
: Package () { _SB.PCI0.TCPU, _SB.PCI0.TCPU, 100, 60, 0, 0, 0, 0 },
Done.
Done
https://review.coreboot.org/c/coreboot/+/35794/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/35794/3/src/mainboard/google/hatch/...
PS3, Line 99: TSR1
Comment needs update?
Done
https://review.coreboot.org/c/coreboot/+/35794/4/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/35794/4/src/mainboard/google/hatch/...
PS4, Line 115: TSR0
Sorry, we lost change annotation to TSR0.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e5c079856a167b1c2ef52e446d055404e565858
Gerrit-Change-Number: 35794
Gerrit-PatchSet: 6
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anson Tseng
anson.tseng@intel.corp-partner.google.com
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 30 Oct 2019 16:57:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Comment-In-Reply-To: Philip Chen
philipchen@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment