[M] Change in coreboot[main]: lib: Refactor ux_locales_get_text API

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun.

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email )

Change subject: lib: Refactor ux_locales_get_text API
......................................................................

Patch Set 2:

(9 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86283/comment/3aec7b3d_0ec4a7b3?usp... :
PS2, Line 14: - ux_locales_get_text: Get UX locales msg based on locales name.
> message.

Acknowledged

https://review.coreboot.org/c/coreboot/+/86283/comment/9be81b27_7e5737e5?usp... :
PS2, Line 15: msg
> message

Acknowledged

https://review.coreboot.org/c/coreboot/+/86283/comment/c0f50acc_1c807310?usp... :
PS2, Line 15: - ux_locales_get_text_by_id - Get UX locales msg based on msg ID.
> Use colon instead of dash

Acknowledged

https://review.coreboot.org/c/coreboot/+/86283/comment/0d245315_3a63c316?usp... :
PS2, Line 17: `ux_locales_get_text_by_id` retrieve fallback text message depending
> retrieves

Acknowledged

https://review.coreboot.org/c/coreboot/+/86283/comment/86cb149f_0339db0c?usp... :
PS2, Line 18: upon the msg ID incase UX locales not available. `ux_locales_get_text`
> s/incase/if/

Acknowledged

File src/include/ux_locales.h:

https://review.coreboot.org/c/coreboot/+/86283/comment/1023cb08_e91a78cf?usp... :
PS2, Line 20: english
> English

Acknowledged

https://review.coreboot.org/c/coreboot/+/86283/comment/65aa4b6a_cca55733?usp... :
PS2, Line 20: fallback_msg
> fallback_text ?

Acknowledged

File src/lib/ux_locales.c:

https://review.coreboot.org/c/coreboot/+/86283/comment/2ce88419_1832fdd8?usp... :
PS2, Line 35: ux_locale_msg_list
> Could we index with `enum ux_locale_msg` avoiding an unnecessary loop?

Acknowledged

https://review.coreboot.org/c/coreboot/+/86283/comment/258fc098_f5052914?usp... :
PS2, Line 225: 	if (!msg_id_found)
> I am wondering if a `printk(BIOS_ERR` would be appropriate in addition to this.

Acknowledged