Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 6:
Aha, I recall now. What is the issue with the current setup? Does it fail to see something is attached on the DP port, or do eDP ports need some additional config to enable the backlight?
It's a historical issue. Originally, libgfxinit (on Ironlake) only
knew LVDS as connector for integrated panels. It was just called
`Internal`. When I added eDP support, I kept the notion of `Inter-
nal` and added a config flag if it's LVDS or the dedicated eDP
port. I didn't know back then, that Intel allows to use other
DP ports in combination with the panel logic, too. But they do.
So, what libgfxinit needs is explicit port types LVDS and eDP
(instead of the `Internal`). And a config to tell what port (can
be any) is used for an integrated panel.
Without the panel logic, timing isn't adhered and maybe there is
a backlight issue, too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 6
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kilian Neuner
cb@9-r.net
Gerrit-CC: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-CC: Tom Hiller
thrilleratplay@gmail.com
Gerrit-Comment-Date: Sun, 27 Jan 2019 14:58:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment