V Sowmya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47290 )
Change subject: mb/intel/adlrvp: Configure the HPD GPIO's ......................................................................
mb/intel/adlrvp: Configure the HPD GPIO's
This patch configures the HPD1 and HPD2 GPIO's.
BUG=:b:170607415 TEST=Built and booted adlrvp. Verified the hotplug functionality is working.
Change-Id: Ied2d4c56220212a15103e9a2fbd01ce6f0811a74 Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/47290/1
diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c b/src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c index e142e88..cda183d 100644 --- a/src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c +++ b/src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c @@ -277,6 +277,10 @@ PAD_CFG_NF(GPP_A21, NONE, DEEP, NF2), PAD_CFG_NF(GPP_A22, NONE, DEEP, NF2),
+ /* HPD_1 (A19) and HPD_2 (A20) pins */ + PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), + /* IMGCLKOUT */ PAD_CFG_NF(GPP_D4, NONE, DEEP, NF1), PAD_CFG_NF(GPP_H20, NONE, DEEP, NF1),
Hello Subrata Banik, Sooraj Govindan, Aamir Bohra,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47290
to look at the new patch set (#2).
Change subject: mb/intel/adlrvp: Configure the HPD GPIO's ......................................................................
mb/intel/adlrvp: Configure the HPD GPIO's
This patch configures the HPD1 and HPD2 GPIO's.
BUG=b:170607415 TEST=Built and booted adlrvp. Verified the hotplug functionality is working.
Change-Id: Ied2d4c56220212a15103e9a2fbd01ce6f0811a74 Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/47290/2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47290 )
Change subject: mb/intel/adlrvp: Configure the HPD GPIO's ......................................................................
Patch Set 2: Code-Review+2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47290 )
Change subject: mb/intel/adlrvp: Configure the HPD GPIO's ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c:
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... PS1, Line 280: /* HPD_1 (A19) and HPD_2 (A20) pins */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... PS1, Line 281: PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... PS1, Line 281: PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... PS1, Line 282: PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... PS1, Line 282: PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), please, no spaces at the start of a line
Hello build bot (Jenkins), Subrata Banik, Sooraj Govindan, Aamir Bohra,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47290
to look at the new patch set (#3).
Change subject: mb/intel/adlrvp: Configure the HPD GPIO's ......................................................................
mb/intel/adlrvp: Configure the HPD GPIO's
This patch configures the HPD1 and HPD2 GPIO's.
BUG=b:170607415 TEST=Built and booted adlrvp. Verified the hotplug functionality is working.
Change-Id: Ied2d4c56220212a15103e9a2fbd01ce6f0811a74 Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/47290/3
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47290 )
Change subject: mb/intel/adlrvp: Configure the HPD GPIO's ......................................................................
Patch Set 3: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47290 )
Change subject: mb/intel/adlrvp: Configure the HPD GPIO's ......................................................................
mb/intel/adlrvp: Configure the HPD GPIO's
This patch configures the HPD1 and HPD2 GPIO's.
BUG=b:170607415 TEST=Built and booted adlrvp. Verified the hotplug functionality is working.
Change-Id: Ied2d4c56220212a15103e9a2fbd01ce6f0811a74 Signed-off-by: V Sowmya v.sowmya@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47290 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c b/src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c index e142e88..c7029fc1 100644 --- a/src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c +++ b/src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c @@ -277,6 +277,10 @@ PAD_CFG_NF(GPP_A21, NONE, DEEP, NF2), PAD_CFG_NF(GPP_A22, NONE, DEEP, NF2),
+ /* HPD_1 (A19) and HPD_2 (A20) pins */ + PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), + /* IMGCLKOUT */ PAD_CFG_NF(GPP_D4, NONE, DEEP, NF1), PAD_CFG_NF(GPP_H20, NONE, DEEP, NF1),
-
build bot (Jenkins) (Code Review) -
Subrata Banik (Code Review)
-
V Sowmya (Code Review)