Attention is currently required from: Tarun Tuli, Dinesh Gehlot, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70272 )
Change subject: soc/intel/meteorlake: Drop casts around `soc_read_pmc_base()` ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70272/comment/66f33c42_399bc819 PS3, Line 9: The `soc_read_pmc_base()` function returns an `uintptr_t`, which is then : casted to a pointer type for use with `read32()` and/or `write32()`. But : since commit b324df6a540d154cc9267c0398654f9142aae052 (arch/x86: Provide : readXp/writeXp helpers in arch/mmio.h), the `read32p()` and `write32p()` : functions live in `arch/mmio.h`. These functions use the `uintptr_t type : for the address parameter instead of a pointer type, and using them with : the `soc_read_pmc_base()` function allows dropping the casts to pointer. : please use < 72 char per line