Change in ...coreboot[master]: mb/google/octopus: Add wifi_default_sar.hex for other sku DUT
Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32332
Change subject: mb/google/octopus: Add wifi_default_sar.hex for other sku DUT ......................................................................
mb/google/octopus: Add wifi_default_sar.hex for other sku DUT
Laser would prefer to use different SAR values. Since Laser sku id is 5. But other sku DUT will apply for default file
BUG=b:130381493 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ia0041a97a35de71f1aad0b07465605435ead598c --- M src/mainboard/google/octopus/variants/phaser/mainboard.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/32332/1
diff --git a/src/mainboard/google/octopus/variants/phaser/mainboard.c b/src/mainboard/google/octopus/variants/phaser/mainboard.c index 2d44830..8d47580 100644 --- a/src/mainboard/google/octopus/variants/phaser/mainboard.c +++ b/src/mainboard/google/octopus/variants/phaser/mainboard.c @@ -27,6 +27,8 @@
if (sku_id == 5) filename = "wifi_sar-laser.hex"; + else + filename = "wifi_default_sar.hex";
return filename; }
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32332 )
Change subject: mb/google/octopus: Add wifi_default_sar.hex for other sku DUT ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32332/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/phaser/mainboard.c:
https://review.coreboot.org/#/c/32332/1/src/mainboard/google/octopus/variant... PS1, Line 31: wifi_default_sar.hex I thought other SKUs did not have a SAR table?
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32332 )
Change subject: mb/google/octopus: Add wifi_default_sar.hex for other sku DUT ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32332/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/phaser/mainboard.c:
https://review.coreboot.org/#/c/32332/1/src/mainboard/google/octopus/variant... PS1, Line 31: wifi_default_sar.hex
I thought other SKUs did not have a SAR table?
Yes, But if no this empty file, only enable WIFI_SAR_CBFS compile code base no work. 1. I mean we must enable WIFI_SAR_CBFS and point to CONFIG_WIFI_SAR_CBFS_FILEPATH, compile is ok 2. if we just use "wifi_sar-laser.hex", and CONFIG_WIFI_SAR_CBFS_FILEPATH point to this file, it will apply to wifi_sar_defaults.hex-file. like :(code directory: src/drivers/intel/wifi/Makefile.inc)
ramstage-$(CONFIG_DRIVERS_INTEL_WIFI) += wifi.c
cbfs-files-$(CONFIG_WIFI_SAR_CBFS) += wifi_sar_defaults.hex wifi_sar_defaults.hex-file := $(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILEPATH)) wifi_sar_defaults.hex-type := raw
Peichao Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32332 )
Change subject: mb/google/octopus: Add wifi_default_sar.hex for other sku DUT ......................................................................
Abandoned
-
Furquan Shaikh (Code Review) -
Peichao Li (Code Review)