Change in coreboot[master]: mb/google/dedede: Add Daughter-board FW_CONFIG in devicetree
Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48191 )
Change subject: mb/google/dedede: Add Daughter-board FW_CONFIG in devicetree ......................................................................
mb/google/dedede: Add Daughter-board FW_CONFIG in devicetree
Add daughter-board ports bit field and mask in devicetree.
BUG=b:161190931 BRANCH=dedede TEST=Build and boot to OS in drawlat & drawman.
Change-Id: Ibbd86fc8c3e44a7d1703b8ce75c48881226545c9 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/48191/1
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index ce28123..2785ad0 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -1,4 +1,11 @@ fw_config + field DB_PORTS 0 3 + option DB_PORTS_NONE 0 + option DB_PORTS_2C_2A 1 + option DB_PORTS_1C_LTE 2 + option DB_PORTS_1A_HDMI 3 + option DB_PORTS_1C_1A 4 + end field TABLETMODE 10 option TABLETMODE_DISABLED 0 option TABLETMODE_ENABLED 1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48191 )
Change subject: mb/google/dedede: Add Daughter-board FW_CONFIG in devicetree ......................................................................
Patch Set 1: Code-Review+2
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48191 )
Change subject: mb/google/dedede: Add Daughter-board FW_CONFIG in devicetree ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Maulik V Vaghela, Marco Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48191
to look at the new patch set (#2).
Change subject: mb/google/dedede: Add Daughter-board FW_CONFIG in devicetree ......................................................................
mb/google/dedede: Add Daughter-board FW_CONFIG in devicetree
Add daughter-board ports bit field and mask in devicetree.
BUG=b:161190931 BRANCH=dedede TEST=Build and boot to OS in drawlat & drawman.
Change-Id: Ibbd86fc8c3e44a7d1703b8ce75c48881226545c9 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/48191/2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48191 )
Change subject: mb/google/dedede: Add Daughter-board FW_CONFIG in devicetree ......................................................................
mb/google/dedede: Add Daughter-board FW_CONFIG in devicetree
Add daughter-board ports bit field and mask in devicetree.
BUG=b:161190931 BRANCH=dedede TEST=Build and boot to OS in drawlat & drawman.
Change-Id: Ibbd86fc8c3e44a7d1703b8ce75c48881226545c9 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48191 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Maulik V Vaghela: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index ce28123..2785ad0 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -1,4 +1,11 @@ fw_config + field DB_PORTS 0 3 + option DB_PORTS_NONE 0 + option DB_PORTS_2C_2A 1 + option DB_PORTS_1C_LTE 2 + option DB_PORTS_1A_HDMI 3 + option DB_PORTS_1C_1A 4 + end field TABLETMODE 10 option TABLETMODE_DISABLED 0 option TABLETMODE_ENABLED 1
-
Furquan Shaikh (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)