Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Krystian Hebel.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69162 )
Change subject: security/tpm: support compiling in multiple TPM drivers ......................................................................
Patch Set 6:
(2 comments)
File src/security/tpm/tis.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163660): https://review.coreboot.org/c/coreboot/+/69162/comment/0402a59d_0d979bd4 PS6, Line 110: #define __tis_driver __attribute__((used, section(".rodata.tis_driver"))) Prefer __used over __attribute__((used))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163660): https://review.coreboot.org/c/coreboot/+/69162/comment/0ce825b7_d82d9000 PS6, Line 110: #define __tis_driver __attribute__((used, section(".rodata.tis_driver"))) Prefer __section(".rodata.tis_driver") over __attribute__((section(".rodata.tis_driver")))