Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48190 )
Change subject: mb/google/deltaur: Restrict RW_DIAG to lower 16MiB ......................................................................
mb/google/deltaur: Restrict RW_DIAG to lower 16MiB
This change restricts RW_DIAG region to lower 16MiB to ensure that the extended BIOS checker for FMAP does not complain about 16MiB boundary crossing.
I haven't updated any other regions to occupy the newly freed space but it is fine since this board is dead and should be dropped from coreboot soon.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I19ab204fbe3e020e42baf68bfa350dcff32066a3 --- M src/mainboard/google/deltaur/chromeos.fmd 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/48190/1
diff --git a/src/mainboard/google/deltaur/chromeos.fmd b/src/mainboard/google/deltaur/chromeos.fmd index bbec112..a84a448 100644 --- a/src/mainboard/google/deltaur/chromeos.fmd +++ b/src/mainboard/google/deltaur/chromeos.fmd @@ -6,9 +6,9 @@ SI_PDR(PRESERVE)@0x602000 0x4000 } SI_BIOS@0x606000 0x19fa000 { - RW_DIAG@0x0 0x10ca000 { - RW_LEGACY(CBFS)@0x0 0x10ba000 - DIAG_NVRAM@0x10ba000 0x10000 + RW_DIAG@0x0 0x9fa000 { + RW_LEGACY(CBFS)@0x0 0x9ea000 + DIAG_NVRAM@0x9ea000 0x10000 } RW_SECTION_A@0x10ca000 0x280000 { VBLOCK_A@0x0 0x10000
Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48190 )
Change subject: mb/google/deltaur: Restrict RW_DIAG to lower 16MiB ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Tim Wawrzynczak, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48190
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Restrict RW_DIAG to lower 16MiB ......................................................................
mb/google/deltaur: Restrict RW_DIAG to lower 16MiB
This change restricts RW_DIAG region to lower 16MiB to ensure that the extended BIOS checker for FMAP does not complain about 16MiB boundary crossing.
I haven't updated any other regions to occupy the newly freed space but it is fine since this board is dead and should be dropped from coreboot soon.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I19ab204fbe3e020e42baf68bfa350dcff32066a3 --- M src/mainboard/google/deltaur/chromeos-gbe.fmd M src/mainboard/google/deltaur/chromeos.fmd 2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/48190/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48190 )
Change subject: mb/google/deltaur: Restrict RW_DIAG to lower 16MiB ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48190 )
Change subject: mb/google/deltaur: Restrict RW_DIAG to lower 16MiB ......................................................................
mb/google/deltaur: Restrict RW_DIAG to lower 16MiB
This change restricts RW_DIAG region to lower 16MiB to ensure that the extended BIOS checker for FMAP does not complain about 16MiB boundary crossing.
I haven't updated any other regions to occupy the newly freed space but it is fine since this board is dead and should be dropped from coreboot soon.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I19ab204fbe3e020e42baf68bfa350dcff32066a3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48190 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/deltaur/chromeos-gbe.fmd M src/mainboard/google/deltaur/chromeos.fmd 2 files changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/chromeos-gbe.fmd b/src/mainboard/google/deltaur/chromeos-gbe.fmd index 9b6fec3..91918e8 100644 --- a/src/mainboard/google/deltaur/chromeos-gbe.fmd +++ b/src/mainboard/google/deltaur/chromeos-gbe.fmd @@ -7,9 +7,9 @@ SI_PDR(PRESERVE)@0x602000 0x4000 } SI_BIOS@0x606000 0x19fa000 { - RW_DIAG@0x0 0x10ca000 { - RW_LEGACY(CBFS)@0x0 0x10ba000 - DIAG_NVRAM@0x10ba000 0x10000 + RW_DIAG@0x0 0x9fa000 { + RW_LEGACY(CBFS)@0x0 0x9ea000 + DIAG_NVRAM@0x9ea000 0x10000 } RW_SECTION_A@0x10ca000 0x280000 { VBLOCK_A@0x0 0x10000 diff --git a/src/mainboard/google/deltaur/chromeos.fmd b/src/mainboard/google/deltaur/chromeos.fmd index bbec112..a84a448 100644 --- a/src/mainboard/google/deltaur/chromeos.fmd +++ b/src/mainboard/google/deltaur/chromeos.fmd @@ -6,9 +6,9 @@ SI_PDR(PRESERVE)@0x602000 0x4000 } SI_BIOS@0x606000 0x19fa000 { - RW_DIAG@0x0 0x10ca000 { - RW_LEGACY(CBFS)@0x0 0x10ba000 - DIAG_NVRAM@0x10ba000 0x10000 + RW_DIAG@0x0 0x9fa000 { + RW_LEGACY(CBFS)@0x0 0x9ea000 + DIAG_NVRAM@0x9ea000 0x10000 } RW_SECTION_A@0x10ca000 0x280000 { VBLOCK_A@0x0 0x10000
-
Furquan Shaikh (Code Review) -
Srinidhi N Kaushik (Code Review)
-
Tim Wawrzynczak (Code Review)