Attention is currently required from: Jes Klinke, Philipp Deppenwiese, Patrick Rudolph, Christian Walter, Werner Zeh. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63285 )
Change subject: Factor TI50/CR50 config ......................................................................
Patch Set 2:
(5 comments)
File src/drivers/tpm/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63285/comment/1a8c4fe5_83cf473f PS2, Line 9: cr50.c I guess the next thing is to rename cr50-related files and folders?
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/63285/comment/ef927929_48a43635 PS2, Line 387: if (CONFIG(CHROMEOS) && (!CONFIG(MAINBOARD_HAS_TPM_GSC))) Does Ti50 support ZTE?
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/63285/comment/0e190082_11db4b12 PS2, Line 25: CR50 Also rename this?
File src/vendorcode/google/chromeos/cse_board_reset.c:
https://review.coreboot.org/c/coreboot/+/63285/comment/9c43bd08_2c9f6fec PS2, Line 41: /* : * Ti50 firmware of all versions support the above PLTRST wiring. : */ /* One line comment. */
https://review.coreboot.org/c/coreboot/+/63285/comment/6d6f6793_d4a880db PS2, Line 47: Remove extra blank line.
-
Yu-Ping Wu (Code Review)