Change in ...coreboot[master]: util/crossgcc: use fixed length version string

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Wonkyu Kim (Code Review)

19 Jan 2019 19 Jan '19

1:50 a.m.

Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31001

Change subject: util/crossgcc: use fixed length version string ......................................................................

util/crossgcc: use fixed length version string

After merging util/crossgcc: derive date and version from latest commit (https://review.coreboot.org/c/coreboot/+/30804), crossgcc build is broken in internal repository due to long version name;coreboot.org repository is ok because it use short tag name. The patch use "git discribe" which is dependent on git tag name. If tag name is little bit long, it can cause crossgcc build failed.

To avoid this issue, use only short version of hash string. It has fixed lenght and it's enough as version as we use date together.

Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/31001/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 211494d..4b5a718 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -31,7 +31,7 @@ cd "$(dirname "$0")" || exit 1

CROSSGCC_DATE="$(git log -n 1 --pretty=%ad --date=short .)" -CROSSGCC_VERSION="$(git describe $(git log -n 1 --pretty=%h .))" +CROSSGCC_VERSION="$(git log -n 1 --pretty=%h .)" CROSSGCC_COMMIT=$( git describe )

# default settings

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Wonkyu Kim (Code Review)

19 Jan 19 Jan

1:53 a.m.

Wonkyu Kim has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/31001 )

Change subject: util/crossgcc: use fixed length version string ......................................................................

util/crossgcc: use fixed length version string

After merging util/crossgcc: derive date and version from latest commit (https://review.coreboot.org/c/coreboot/+/30804), crossgcc build is broken in internal repository due to long version name;coreboot.org repository is ok because it uses short tag name. The patch uses "git discribe" which is dependent on git tag name. If tag name is little bit long, it can cause crossgcc build failed.

To avoid this issue, use only short version of hash string which is fixed lenght. And it's enough as version string because we use date(CROSSGCC_DATE) together.

Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/31001/2

Wonkyu Kim (Code Review)

2:03 a.m.

New subject: Change in ...coreboot[master]: util/crossgcc: use fixed length version string.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31001

to look at the new patch set (#3).

Change subject: util/crossgcc: use fixed length version string. ......................................................................

util/crossgcc: use fixed length version string.

After merging util/crossgcc: derive date and version from latest commit (https://review.coreboot.org/c/coreboot/+/30804), crossgcc build is broken in internal repository due to long version name;coreboot.org repository is ok because it uses short tag name. The patch uses "git describe" which is dependent on git tag name. If tag name is little bit long, it can cause crossgcc build failed.

To avoid this issue, use only short version of hash string which is fixed length. And it's enough as version string because we use date(CROSSGCC_DATE) together.

TEST=Build crossgcc in both coreboot.org and internal repository which uses longer tag name and check version string in build log.

Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/31001/3

Lijian Zhao (Code Review)

9:32 p.m.

New subject: Change in ...coreboot[master]: util/crossgcc: use fixed length version string.

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31001 )

Change subject: util/crossgcc: use fixed length version string. ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/31001/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31001/3//COMMIT_MSG@16 PS3, Line 16: fixed length. More than 80

https://review.coreboot.org/#/c/31001/3//COMMIT_MSG@17 PS3, Line 17: together. More than 80

-- To view, visit https://review.coreboot.org/c/coreboot/+/31001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Gerrit-Change-Number: 31001 Gerrit-PatchSet: 3 Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: Boon Tiong Teo boon.tiong.teo@intel.com Gerrit-Reviewer: Hannah Williams hannah.williams@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 19 Jan 2019 21:32:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Wonkyu Kim (Code Review)

22 Jan 22 Jan

7:21 p.m.

New subject: Change in ...coreboot[master]: util/crossgcc: use fixed length version string.

Hello Srinidhi N Kaushik, Stefan Reinauer, Boon Tiong Teo, Lijian Zhao, build bot (Jenkins), Hannah Williams, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31001

to look at the new patch set (#5).

Change subject: util/crossgcc: use fixed length version string. ......................................................................

util/crossgcc: use fixed length version string.

After merging util/crossgcc: derive date and version from latest commit (https://review.coreboot.org/c/coreboot/+/30804), crossgcc build is broken in internal repository due to long version name;coreboot.org repository is ok because it uses short tag name. The patch uses "git describe" which is dependent on git tag name. If tag name is little bit long, it can cause crossgcc build failed.

To avoid this issue, use only short version of hash string which is fixed length. And it's enough as version string, because we also use date(CROSSGCC_DATE) together.

TEST=Build crossgcc in both coreboot.org and internal repository which uses longer tag name and check version string in build log.

Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/31001/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/31001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Gerrit-Change-Number: 31001 Gerrit-PatchSet: 5 Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: Boon Tiong Teo boon.tiong.teo@intel.com Gerrit-Reviewer: Hannah Williams hannah.williams@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Wonkyu Kim (Code Review)

7:21 p.m.

New subject: Change in ...coreboot[master]: util/crossgcc: use fixed length version string.

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31001 )

Change subject: util/crossgcc: use fixed length version string. ......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/31001/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31001/3//COMMIT_MSG@16 PS3, Line 16: fixed length.

...

More than 80

Done

https://review.coreboot.org/#/c/31001/3//COMMIT_MSG@17 PS3, Line 17: together.

...

More than 80

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/31001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Gerrit-Change-Number: 31001 Gerrit-PatchSet: 5 Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: Boon Tiong Teo boon.tiong.teo@intel.com Gerrit-Reviewer: Hannah Williams hannah.williams@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 22 Jan 2019 19:21:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Lijian Zhao lijian.zhao@intel.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7:45 p.m.

New subject: Change in ...coreboot[master]: util/crossgcc: use fixed length version string.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31001 )

Change subject: util/crossgcc: use fixed length version string. ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Gerrit-Change-Number: 31001 Gerrit-PatchSet: 5 Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: Boon Tiong Teo boon.tiong.teo@intel.com Gerrit-Reviewer: Hannah Williams hannah.williams@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 22 Jan 2019 19:45:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7:45 p.m.

New subject: Change in ...coreboot[master]: util/crossgcc: use fixed length version string.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31001 )

Change subject: util/crossgcc: use fixed length version string. ......................................................................

util/crossgcc: use fixed length version string.

After merging util/crossgcc: derive date and version from latest commit (https://review.coreboot.org/c/coreboot/+/30804), crossgcc build is broken in internal repository due to long version name;coreboot.org repository is ok because it uses short tag name. The patch uses "git describe" which is dependent on git tag name. If tag name is little bit long, it can cause crossgcc build failed.

To avoid this issue, use only short version of hash string which is fixed length. And it's enough as version string, because we also use date(CROSSGCC_DATE) together.

TEST=Build crossgcc in both coreboot.org and internal repository which uses longer tag name and check version string in build log.

Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-on: https://review.coreboot.org/c/31001 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 211494d..4b5a718 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -31,7 +31,7 @@ cd "$(dirname "$0")" || exit 1

# default settings

-- To view, visit https://review.coreboot.org/c/coreboot/+/31001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Gerrit-Change-Number: 31001 Gerrit-PatchSet: 6 Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: Boon Tiong Teo boon.tiong.teo@intel.com Gerrit-Reviewer: Hannah Williams hannah.williams@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

Wonkyu Kim (Code Review)

7:50 p.m.

New subject: Change in ...coreboot[master]: util/crossgcc: use fixed length version string.

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31001 )

Change subject: util/crossgcc: use fixed length version string. ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I405b2e4e5c05831c25aebf1c73a281adab8ef452 Gerrit-Change-Number: 31001 Gerrit-PatchSet: 5 Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: Boon Tiong Teo boon.tiong.teo@intel.com Gerrit-Reviewer: Hannah Williams hannah.williams@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 22 Jan 2019 19:50:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2138

days inactive

2141

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Lijian Zhao (Code Review)
Patrick Georgi (Code Review)
Wonkyu Kim (Code Review)