Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40961 )
Change subject: asus/p2b: Align IDE settings, enable UDMA for all variants ......................................................................
asus/p2b: Align IDE settings, enable UDMA for all variants
Enable UDMA on all IDE interfaces for all variants. There's no reason not to.
Change-Id: I12c9e0f66c437d8add5c4096fd2a5e747d082799 Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b/devicetree.cb M src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb M src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb 3 files changed, 4 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/40961/1
diff --git a/src/mainboard/asus/p2b/devicetree.cb b/src/mainboard/asus/p2b/devicetree.cb index 9dcd1da..9f7f63e 100644 --- a/src/mainboard/asus/p2b/devicetree.cb +++ b/src/mainboard/asus/p2b/devicetree.cb @@ -46,10 +46,10 @@ register "ide1_enable" = "1" register "ide_legacy_enable" = "1" # Enable UDMA/33 for higher speed if your IDE device(s) support it. - register "ide0_drive0_udma33_enable" = "0" - register "ide0_drive1_udma33_enable" = "0" - register "ide1_drive0_udma33_enable" = "0" - register "ide1_drive1_udma33_enable" = "0" + register "ide0_drive0_udma33_enable" = "1" + register "ide0_drive1_udma33_enable" = "1" + register "ide1_drive0_udma33_enable" = "1" + register "ide1_drive1_udma33_enable" = "1" register "thrm_polarity" = "1" register "lid_polarity" = "1" end diff --git a/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb b/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb index 7424144..ce36ce6 100644 --- a/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb +++ b/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb @@ -17,14 +17,6 @@ end end end - register "ide0_enable" = "1" - register "ide1_enable" = "1" - register "ide_legacy_enable" = "1" - # Enable UDMA/33 for higher speed if your IDE device(s) support it. - register "ide0_drive0_udma33_enable" = "1" - register "ide0_drive1_udma33_enable" = "1" - register "ide1_drive0_udma33_enable" = "1" - register "ide1_drive1_udma33_enable" = "1" end end end diff --git a/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb b/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb index 6eabe58..b261a35 100644 --- a/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb +++ b/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb @@ -18,14 +18,6 @@ end end device pci 6.0 on end # Onboard SCSI - register "ide0_enable" = "1" - register "ide1_enable" = "1" - register "ide_legacy_enable" = "1" - # Enable UDMA/33 for higher speed if your IDE device(s) support it. - register "ide0_drive0_udma33_enable" = "1" - register "ide0_drive1_udma33_enable" = "1" - register "ide1_drive0_udma33_enable" = "1" - register "ide1_drive1_udma33_enable" = "1" end end end
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40961 )
Change subject: asus/p2b: Align IDE settings, enable UDMA for all variants ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40961/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40961/1//COMMIT_MSG@7 PS1, Line 7: asus/p2b: Align IDE settings, enable UDMA for all variants I would suggest:
mb/asus/p2b: Enable IDE and UDMA for all variants
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40961
to look at the new patch set (#2).
Change subject: asus/p2b: Enable IDE and UDMA for all variants ......................................................................
asus/p2b: Enable IDE and UDMA for all variants
There's no reason not to.
Change-Id: I12c9e0f66c437d8add5c4096fd2a5e747d082799 Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b/devicetree.cb M src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb M src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb 3 files changed, 4 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/40961/2
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40961 )
Change subject: asus/p2b: Enable IDE and UDMA for all variants ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40961/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40961/1//COMMIT_MSG@7 PS1, Line 7: asus/p2b: Align IDE settings, enable UDMA for all variants
I would suggest: […]
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40961 )
Change subject: asus/p2b: Enable IDE and UDMA for all variants ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40961 )
Change subject: asus/p2b: Enable IDE and UDMA for all variants ......................................................................
asus/p2b: Enable IDE and UDMA for all variants
There's no reason not to.
Change-Id: I12c9e0f66c437d8add5c4096fd2a5e747d082799 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40961 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/asus/p2b/devicetree.cb M src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb M src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb 3 files changed, 4 insertions(+), 20 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/mainboard/asus/p2b/devicetree.cb b/src/mainboard/asus/p2b/devicetree.cb index 9dcd1da..9f7f63e 100644 --- a/src/mainboard/asus/p2b/devicetree.cb +++ b/src/mainboard/asus/p2b/devicetree.cb @@ -46,10 +46,10 @@ register "ide1_enable" = "1" register "ide_legacy_enable" = "1" # Enable UDMA/33 for higher speed if your IDE device(s) support it. - register "ide0_drive0_udma33_enable" = "0" - register "ide0_drive1_udma33_enable" = "0" - register "ide1_drive0_udma33_enable" = "0" - register "ide1_drive1_udma33_enable" = "0" + register "ide0_drive0_udma33_enable" = "1" + register "ide0_drive1_udma33_enable" = "1" + register "ide1_drive0_udma33_enable" = "1" + register "ide1_drive1_udma33_enable" = "1" register "thrm_polarity" = "1" register "lid_polarity" = "1" end diff --git a/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb b/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb index 7424144..ce36ce6 100644 --- a/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb +++ b/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb @@ -17,14 +17,6 @@ end end end - register "ide0_enable" = "1" - register "ide1_enable" = "1" - register "ide_legacy_enable" = "1" - # Enable UDMA/33 for higher speed if your IDE device(s) support it. - register "ide0_drive0_udma33_enable" = "1" - register "ide0_drive1_udma33_enable" = "1" - register "ide1_drive0_udma33_enable" = "1" - register "ide1_drive1_udma33_enable" = "1" end end end diff --git a/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb b/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb index 6eabe58..b261a35 100644 --- a/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb +++ b/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb @@ -18,14 +18,6 @@ end end device pci 6.0 on end # Onboard SCSI - register "ide0_enable" = "1" - register "ide1_enable" = "1" - register "ide_legacy_enable" = "1" - # Enable UDMA/33 for higher speed if your IDE device(s) support it. - register "ide0_drive0_udma33_enable" = "1" - register "ide0_drive1_udma33_enable" = "1" - register "ide1_drive0_udma33_enable" = "1" - register "ide1_drive1_udma33_enable" = "1" end end end
-
Angel Pons (Code Review) -
Keith Hui (Code Review)
-
Patrick Georgi (Code Review)