Attention is currently required from: Furquan Shaikh, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55226 )
Change subject: soc/intel: Drop unused lpss functions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
looks like cannonlake does
src/soc/intel/cannonlake/fsp_params.c:32:28: error: 'serial_io_dev' undeclared (first use in this function); did you mean 'serirq_mode'?
dev = pcidev_path_on_root(serial_io_dev[dev_offset]);
^~~~~~~~~~~~~
serirq_mode
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27bdfbca7c199e823a0e4fdb277e3f22fb6bae7a
Gerrit-Change-Number: 55226
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 04 Jun 2021 16:46:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment