Attention is currently required from: Raul Rangel, Tim Wawrzynczak, Jon Murphy. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63968 )
Change subject: drivers/usb: Add chip driver for VL822 USB hub ......................................................................
Patch Set 2:
(2 comments)
File src/drivers/usb/vl/acpi_vl822.c:
https://review.coreboot.org/c/coreboot/+/63968/comment/3da5d507_cbc394d0 PS2, Line 91: ViaLabs VL822
Nothing about this file looks like it's VL822 specific. […]
I agree. There is nothing specific about this driver for VL822. I can rename it to a generic USB hub
File src/drivers/usb/vl/chip.h:
https://review.coreboot.org/c/coreboot/+/63968/comment/48d109c7_17ca5fb1 PS2, Line 9: port_count
Or maybe we add a port_count parameter to the existing `drivers/usb/acpi` and change this condition? […]
I thought about this approach such that USB hub driver is integrated with USB ACPI driver. But the acpi_name operation for the USB leaf node (i.e. downstream ports) has to be NULL such that the hub(parent) can define the ACPI name for them. Once it is defined and returns NULL as ACPI name for leaf nodes, then it breaks the ACPI path for leaf nodes.
https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...