build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit ......................................................................
Patch Set 18:
(3 comments)
https://review.coreboot.org/#/c/30414/18/src/mainboard/facebook/fbg1701/irqr... File src/mainboard/facebook/fbg1701/irqroute.h:
https://review.coreboot.org/#/c/30414/18/src/mainboard/facebook/fbg1701/irqr... PS18, Line 40: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/18/src/mainboard/facebook/fbg1701/irqr... PS18, Line 62: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/18/src/mainboard/facebook/fbg1701/roms... File src/mainboard/facebook/fbg1701/romstage.c:
https://review.coreboot.org/#/c/30414/18/src/mainboard/facebook/fbg1701/roms... PS18, Line 100: status = mboot_hash_extend_log(activePcr, 0, (uint8_t *)crtm_version, line over 80 characters