Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30872 )
Change subject: [WIP] arch/x86: Add symbols for CAR MTRRs in linker script
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30872/4/src/arch/x86/car.ld
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/30872/4/src/arch/x86/car.ld@101
PS4, Line 101:
: _car_mtrr_size = _car_mtrr_end - _car_mtrr_start;
: _car_mtrr_sz_log2 = 1 << LOG2CEIL(_car_mtrr_size);
: _car_mtrr_mask = ~(MAX(4096, _car_mtrr_sz_log2) - 1);
apollolake uses 768K and uses 2 MTRR's to set that up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef3546d2bfea2d4d8f87aaf8376e5566fd6aaa
Gerrit-Change-Number: 30872
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 08 Nov 2019 10:15:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment