Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47763 )
Change subject: soc/intel/xeon_sp: Hook up the PMC driver ......................................................................
soc/intel/xeon_sp: Hook up the PMC driver
The soc code was already there but it was never linked.
Change-Id: I75ee08dab524bc40f1630612f93cbd42025b6d4e Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/xeon_sp/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47763/1
diff --git a/src/soc/intel/xeon_sp/Kconfig b/src/soc/intel/xeon_sp/Kconfig index 3d3e803..37c74dc 100644 --- a/src/soc/intel/xeon_sp/Kconfig +++ b/src/soc/intel/xeon_sp/Kconfig @@ -49,6 +49,8 @@ select SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SUPPORT select SOC_INTEL_COMMON_BLOCK_GPIO_PADCFG_PADTOL select SOC_INTEL_COMMON_BLOCK_PCR + select SOC_INTEL_COMMON_BLOCK_PMC + select SOC_INTEL_COMMON_BLOCK_PMC_DISCOVERABLE select TSC_MONOTONIC_TIMER select UDELAY_TSC select SUPPORT_CPU_UCODE_IN_CBFS @@ -56,6 +58,8 @@ select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select FSP_CAR select NO_SMM + select ACPI_INTEL_HARDWARE_SLEEP_VALUES + select REG_SCRIPT
config MAINBOARD_USES_FSP2_0 bool
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47763 )
Change subject: soc/intel/xeon_sp: Hook up the PMC driver ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47763
to look at the new patch set (#2).
Change subject: soc/intel/xeon_sp: Hook up the PMC driver ......................................................................
soc/intel/xeon_sp: Hook up the PMC driver
The soc code was already there but it was never linked.
Change-Id: I75ee08dab524bc40f1630612f93cbd42025b6d4e Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/xeon_sp/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47763/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47763 )
Change subject: soc/intel/xeon_sp: Hook up the PMC driver ......................................................................
Patch Set 2: Code-Review+2
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47763 )
Change subject: soc/intel/xeon_sp: Hook up the PMC driver ......................................................................
soc/intel/xeon_sp: Hook up the PMC driver
The soc code was already there but it was never linked.
Change-Id: I75ee08dab524bc40f1630612f93cbd42025b6d4e Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/47763 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/xeon_sp/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/xeon_sp/Kconfig b/src/soc/intel/xeon_sp/Kconfig index 5c7a667..ea38dfd 100644 --- a/src/soc/intel/xeon_sp/Kconfig +++ b/src/soc/intel/xeon_sp/Kconfig @@ -50,6 +50,8 @@ select SOC_INTEL_COMMON_BLOCK_GPIO_PADCFG_PADTOL select SOC_INTEL_COMMON_BLOCK_PCR select SOC_INTEL_COMMON_BLOCK_P2SB + select SOC_INTEL_COMMON_BLOCK_PMC + select SOC_INTEL_COMMON_BLOCK_PMC_DISCOVERABLE select TSC_MONOTONIC_TIMER select UDELAY_TSC select SUPPORT_CPU_UCODE_IN_CBFS @@ -57,6 +59,8 @@ select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select FSP_CAR select NO_SMM + select ACPI_INTEL_HARDWARE_SLEEP_VALUES + select REG_SCRIPT
config MAINBOARD_USES_FSP2_0 bool
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)