Attention is currently required from: Martin Roth, Furquan Shaikh, Aseda Aboagye, Aaron Durbin.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52147 )
Change subject: soc/intel: Remove SMM HECI disable related options
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/cannonlake/smihandler.c:
https://review.coreboot.org/c/coreboot/+/52147/comment/1e354fb5_bd971ee5
PS2, Line 22: const struct device *dev = pcidev_path_on_root(PCH_DEVFN_CSE);
: if (!is_dev_enabled(dev))
CNL doesn't consult the devicetree here. […]
The concerned PCI device (device pci 16.0) is also enabled/disabled in devicetree. So I believe the check is sufficient.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iced84faaab8a0cca8400ccd3ec6e4cd525c30e92
Gerrit-Change-Number: 52147
Gerrit-PatchSet: 3
Gerrit-Owner: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 09 Apr 2021 00:02:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aseda Aboagye
aaboagye@google.com
Gerrit-MessageType: comment