Change in coreboot[master]: soc/intel/apollolake: Fix BUG-message when checking for XDCI device

[Werner Zeh (Code Review)]

Attention is currently required from: Nico Huber, Furquan Shaikh, Paul Menzel, Andrey Petrov, Patrick Rudolph.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58524 )

Change subject: soc/intel/apollolake: Fix BUG-message when checking for XDCI device
......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/58524/comment/67f770bc_5b06d96b 
PS1, Line 10: If this
            : device (00:15.1, XDCI) is disabled in devicetree this will trigger the
            : message 'BUG: check_xdci_enable requests hidden 00:15.1' in the log.
> Why is the bug shown?

At this late point in time the devicetree has been parsed so far and disabled devices have been removed from it. Accessing them in a static manner triggers the BUG. I have added this to the commit message.

https://review.coreboot.org/c/coreboot/+/58524/comment/a482c97b_9a6d7ed4 
PS1, Line 17: fix
> fixed

Ack

File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/c/coreboot/+/58524/comment/864d5364_5b09f1ec 
PS1, Line 748: uint16_t xdci_did = PCI_DEVICE_ID_INTEL_APL_XDCI;
             : 
             : 	if (CONFIG(SOC_INTEL_GEMINILAKE))
             : 		xdci_did = PCI_DEVICE_ID_INTEL_GLK_XDCI;
> Maybe: […]

Nico had a better way of doing it yesterday on IRC. I switched to his approach where it is not needed anymore.